Refactor ipmi tests as table-driven tests

Also prefix each sensor line.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>

internal/app/wwctl/node/sensors/main.go

@@ -3,6 +3,7 @@ package sensors
 import (
 	"fmt"
 	"os"
+	"strings"
 
 	"github.com/spf13/cobra"
 	"github.com/warewulf/warewulf/internal/pkg/batch"
@@ -75,12 +76,16 @@ func CobraRunE(vars *variables) func(cmd *cobra.Command, args []string) (err err
 			out, err := result.Result()
 
 			if err != nil {
-				wwlog.Error("%s: %s", result.Ipaddr, out)
+				for _, line := range strings.Split(out, "\n") {
+					wwlog.Error("%s: %s", result.Ipaddr, line)
+				}
 				returnErr = err
 				continue
 			}
 
-			wwlog.Info("%s:\n%s\n", result.Ipaddr, out)
+			for _, line := range strings.Split(out, "\n") {
+				wwlog.Info("%s: %s", result.Ipaddr, line)
+			}
 		}
 
 		return returnErr

internal/app/wwctl/node/sensors/root_test.go

@@ -11,10 +11,10 @@ import (
 	"github.com/warewulf/warewulf/internal/pkg/wwlog"
 )
 
-func Test_Power_Status(t *testing.T) {
+func Test_Sensors(t *testing.T) {
+	warewulfd.SetNoDaemon()
 	env := testenv.New(t)
 	defer env.RemoveAll(t)
-
 	env.WriteFile(t, "etc/warewulf/nodes.conf", `WW_INTERNAL: 43
 nodeprofiles:
   default:
@@ -27,16 +27,28 @@ nodes:
     - default
     ipmi:
       ipaddr: 10.10.10.10`)
-	warewulfd.SetNoDaemon()
-	t.Run("ipmitool status test", func(t *testing.T) {
-		baseCmd := GetCommand()
-		buf := new(bytes.Buffer)
-		baseCmd.SetOut(buf)
-		baseCmd.SetErr(buf)
-		wwlog.SetLogWriter(buf)
-		baseCmd.SetArgs([]string{"--show", "n01"})
-		err := baseCmd.Execute()
-		assert.NoError(t, err)
-		assert.Equal(t, "10.10.10.10:\nipmitool -I lan -H 10.10.10.10 -p 623 -U admin -P admin -e ~ sdr list", strings.TrimSpace(buf.String()))
-	})
+
+	tests := map[string]struct {
+		args     []string
+		expected string
+	}{
+		"sensors": {
+			args:     []string{"--show", "n01"},
+			expected: "10.10.10.10: ipmitool -I lan -H 10.10.10.10 -p 623 -U admin -P admin -e ~ sdr list",
+		},
+	}
+
+	for name, tt := range tests {
+		t.Run(name, func(t *testing.T) {
+			baseCmd := GetCommand()
+			buf := new(bytes.Buffer)
+			baseCmd.SetOut(buf)
+			baseCmd.SetErr(buf)
+			wwlog.SetLogWriter(buf)
+			baseCmd.SetArgs(tt.args)
+			err := baseCmd.Execute()
+			assert.NoError(t, err)
+			assert.Equal(t, strings.TrimSpace(tt.expected), strings.TrimSpace(buf.String()))
+		})
+	}
 }