From 15aa081dd163bdcce9c7f7bcfeae661079282e34 Mon Sep 17 00:00:00 2001
From: Jonathon Anderson <janderson@ciq.com>
Date: Sat, 21 Sep 2024 22:42:51 -0600
Subject: [PATCH] Move restoration of old umask to a defer

Suggested in comment on PR #941

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
---
 internal/pkg/configure/tftp.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/internal/pkg/configure/tftp.go b/internal/pkg/configure/tftp.go
index 3a6633c7..c693cb5d 100644
--- a/internal/pkg/configure/tftp.go
+++ b/internal/pkg/configure/tftp.go
@@ -15,11 +15,11 @@ func TFTP() (err error) {
 	controller := warewulfconf.Get()
 	var tftpdir string = path.Join(controller.TFTP.TftpRoot, "warewulf")
 	oldMask := unix.Umask(0)
+	defer unix.Umask(oldMask)
 	err = os.MkdirAll(tftpdir, 0755)
 	if err != nil {
 		return
 	}
-	_ = unix.Umask(oldMask)
 
 	if controller.Warewulf.GrubBoot {
 		err := warewulfd.CopyShimGrub()