kelvin/warewulf
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix sfdisk overlay for fresh disks by forcing GPT label

Browse Source 
Fixes #2025
This commit is contained in:
kosmolito
2025-09-28 09:50:13 +00:00
committed by Jonathon Anderson
parent a16d92f56e
commit 1c11eaff09
4 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -31,6 +31,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Set dnsmasq to listen to the Warewulf interface to prevent to binding to localhost:53
- Added Ipv6 support to `/etc/hosts` on host and nodes.
- Added IPv6 support to wwclient
- `sfdisk` overlay creates a GPT label when wiping disks. #2025
### Removed

1
CONTRIBUTORS.md
View File

@@ -49,3 +49,4 @@
* Arian Cabrera [@acabrera86](https://github.com/acabrera86)
* Dacian Reece-Stremtan <dacianstremtan@gmail.com> [@dacianstremtan](https://github.com/dacianstremtan)
* Adrian Reber <areber@redhat.com>
* Karker Said <said.karker@gmail.com>

6
overlays/sfdisk/internal/sfdisk_test.go
View File

@@ -181,7 +181,7 @@ if ! command -v sfdisk >/dev/null ; then
info "warewulf: sfdisk not found, skipping partitioning"
else :
info "warewulf: sfdisk: partitioning /dev/sda"
sfdisk --wipe "auto" "/dev/sda" < "${PREFIX}/warewulf/sfdisk/device-0" || die "warewulf: sfdisk: failed to partition /dev/sda"
sfdisk --label gpt --wipe "auto" "/dev/sda" < "${PREFIX}/warewulf/sfdisk/device-0" || die "warewulf: sfdisk: failed to partition /dev/sda"
if command -v blockdev >/dev/null ; then
info "warewulf: blockdev: re-reading partition table"
@@ -238,14 +238,14 @@ if ! command -v sfdisk >/dev/null ; then
info "warewulf: sfdisk not found, skipping partitioning"
else :
info "warewulf: sfdisk: partitioning /dev/sda"
sfdisk --wipe "auto" "/dev/sda" < "${PREFIX}/warewulf/sfdisk/device-0" || die "warewulf: sfdisk: failed to partition /dev/sda"
sfdisk --label gpt --wipe "auto" "/dev/sda" < "${PREFIX}/warewulf/sfdisk/device-0" || die "warewulf: sfdisk: failed to partition /dev/sda"
if command -v blockdev >/dev/null ; then
info "warewulf: blockdev: re-reading partition table"
blockdev --rereadpt /dev/sda
fi
info "warewulf: sfdisk: partitioning /dev/sdb"
sfdisk --wipe "always" "/dev/sdb" < "${PREFIX}/warewulf/sfdisk/device-1" || die "warewulf: sfdisk: failed to partition /dev/sdb"
sfdisk --label gpt --wipe "always" "/dev/sdb" < "${PREFIX}/warewulf/sfdisk/device-1" || die "warewulf: sfdisk: failed to partition /dev/sdb"
if command -v blockdev >/dev/null ; then
info "warewulf: blockdev: re-reading partition table"

2
overlays/sfdisk/rootfs/warewulf/wwinit.d/10-sfdisk.sh.ww
View File

@@ -33,7 +33,7 @@ else :
{{- range $i, $device := $disks }}
{{- if $device.device }}
info "warewulf: sfdisk: partitioning {{ $device.device }}"
sfdisk --wipe "{{ default "auto" $device.wipe }}" "{{ $device.device }}" < "${PREFIX}/warewulf/sfdisk/device-{{ $i }}" || die "warewulf: sfdisk: failed to partition {{ $device.device }}"
sfdisk --label gpt --wipe "{{ default "auto" $device.wipe }}" "{{ $device.device }}" < "${PREFIX}/warewulf/sfdisk/device-{{ $i }}" || die "warewulf: sfdisk: failed to partition {{ $device.device }}"
if command -v blockdev >/dev/null ; then
info "warewulf: blockdev: re-reading partition table"