From 103852df78791c6b4a8950b0ae1a803d016f4c92 Mon Sep 17 00:00:00 2001 From: griznog Date: Mon, 22 Jul 2024 10:19:34 -0500 Subject: [PATCH 1/2] Sanitize/escape asset tag strings from dmidecode. --- internal/app/wwclient/root.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/app/wwclient/root.go b/internal/app/wwclient/root.go index 3f9c08b3..c44be6f0 100644 --- a/internal/app/wwclient/root.go +++ b/internal/app/wwclient/root.go @@ -6,6 +6,7 @@ import ( "log" "net" "net/http" + "net/url" "os" "os/exec" "os/signal" @@ -129,7 +130,7 @@ func CobraRunE(cmd *cobra.Command, args []string) (err error) { if tag == "Unknown" { dmiOut, err := exec.Command("dmidecode", "-s", "chassis-asset-tag").Output() if err == nil { - chassisAssetTag := strings.TrimSpace(string(dmiOut)) + chassisAssetTag := url.QueryEscape(strings.TrimSpace(string(dmiOut))) if chassisAssetTag != "" { tag = chassisAssetTag } From 15bb3f2d965e655932ae0a7f4f6e62e268cdc86d Mon Sep 17 00:00:00 2001 From: griznog Date: Mon, 22 Jul 2024 10:19:50 -0500 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9e00980f..9ab86881 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,6 +44,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Ensure autobuilt overlays include contextual overlay contents. #1296 - Fix the failure when updating overlay files existing on different partitions. #1312 +- Escape asset tag for `wwclient` query strings when pulling runtime overlays. #1310 ## v4.5.5, 2024-07-05