Fix writing of nodes.conf

The caching functionality of nodes.conf, and the optional persistence
functionality that came with it, appears to have been preventing
actually writing the configuration to disk in all cases. This change
fixes the ability to write to nodes.conf.

Somewhat opinionatedly, this change removes the caching functionality of
nodes.conf. The tests have also been updated to use real files for i/o
rather than tying into the caching system, making them more accurately
test the ability of Warewulf to actually read and write its
configuration.

Fixes #779

Signed-off-by: Jonathon Anderson <janderson@ciq.co>

internal/app/wwctl/container/list/main_test.go

@@ -60,7 +60,7 @@ WW_INTERNAL: 0
 	assert.NoError(t, err)
 	warewulfd.SetNoDaemon()
 	for _, tt := range tests {
-		_, err = node.TestNew([]byte(tt.inDb))
+		_, err = node.Parse([]byte(tt.inDb))
 		assert.NoError(t, err)
 		t.Logf("Running test: %s\n", tt.name)
 		t.Run(tt.name, func(t *testing.T) {

internal/app/wwctl/node/add/main.go

@@ -35,7 +35,7 @@ func CobraRunE(vars *variables) func(cmd *cobra.Command, args []string) error {
 		}
 		buffer, err := yaml.Marshal(vars.nodeConf)
 		if err != nil {
-			wwlog.Error("Cant marshall nodeInfo", err)
+			wwlog.Error("Can't marshall nodeInfo", err)
 			return err
 		}
 		set := wwapiv1.NodeAddParameter{

internal/app/wwctl/node/add/main_test.go

@@ -2,6 +2,7 @@ package add
 
 import (
 	"bytes"
+	"os"
 	"testing"
 
 	"github.com/hpcng/warewulf/internal/pkg/node"
@@ -235,21 +236,28 @@ nodes:
         ipaddr: 10.10.0.3
 `},
 	}
-	conf_yml := `
-WW_INTERNAL: 0
-    `
-	nodes_yml := `
-WW_INTERNAL: 43
-`
-	conf := warewulfconf.New()
-	err := conf.Read([]byte(conf_yml))
-	assert.NoError(t, err)
-	db, err := node.TestNew([]byte(nodes_yml))
-	assert.NoError(t, err)
+	conf_yml := `WW_INTERNAL: 0`
+	tempWarewulfConf, warewulfConfErr := os.CreateTemp("", "warewulf.conf-")
+	assert.NoError(t, warewulfConfErr)
+	defer os.Remove(tempWarewulfConf.Name())
+	_, warewulfConfErr = tempWarewulfConf.Write([]byte(conf_yml))
+	assert.NoError(t, warewulfConfErr)
+	assert.NoError(t, tempWarewulfConf.Sync())
+	warewulfconf.ConfigFile = tempWarewulfConf.Name()
+
+	nodes_yml := `WW_INTERNAL: 43`
+	tempNodeConf, nodesConfErr := os.CreateTemp("", "nodes.conf-")
+	assert.NoError(t, nodesConfErr)
+	defer os.Remove(tempNodeConf.Name())
+	node.ConfigFile = tempNodeConf.Name()
 	warewulfd.SetNoDaemon()
 	for _, tt := range tests {
-		db, err = node.TestNew([]byte(nodes_yml))
+		var err error
+		_, err = tempNodeConf.Seek(0, 0)
 		assert.NoError(t, err)
+		assert.NoError(t, tempNodeConf.Truncate(0))
+		_, err = tempNodeConf.Write([]byte(nodes_yml))
+		assert.NoError(t, tempNodeConf.Sync())
 		t.Logf("Running test: %s\n", tt.name)
 		t.Run(tt.name, func(t *testing.T) {
 			baseCmd := GetCommand()
@@ -262,7 +270,10 @@ WW_INTERNAL: 43
 				t.Errorf("Got unwanted error: %s", err)
 				t.FailNow()
 			}
-			dump := string(db.DBDump())
+			config, configErr := node.New()
+			assert.NoError(t, configErr)
+			dumpBytes, _ := config.Dump()
+			dump := string(dumpBytes)
 			if dump != tt.outDb {
 				t.Errorf("DB dump is wrong, got:'%s'\nwant:'%s'", dump, tt.outDb)
 				t.FailNow()

internal/app/wwctl/node/list/main_test.go

@@ -35,17 +35,27 @@ nodes:
     - default
 `},
 	}
-	conf_yml := `
-WW_INTERNAL: 0
-    `
-	conf := warewulfconf.New()
-	err := conf.Read([]byte(conf_yml))
-	assert.NoError(t, err)
-	assert.NoError(t, err)
+	conf_yml := `WW_INTERNAL: 0`
+	tempWarewulfConf, warewulfConfErr := os.CreateTemp("", "warewulf.conf-")
+	assert.NoError(t, warewulfConfErr)
+	defer os.Remove(tempWarewulfConf.Name())
+	_, warewulfConfErr = tempWarewulfConf.Write([]byte(conf_yml))
+	assert.NoError(t, warewulfConfErr)
+	assert.NoError(t, tempWarewulfConf.Sync())
+	warewulfconf.ConfigFile = tempWarewulfConf.Name()
+
+	tempNodeConf, nodesConfErr := os.CreateTemp("", "nodes.conf-")
+	assert.NoError(t, nodesConfErr)
+	defer os.Remove(tempNodeConf.Name())
+	node.ConfigFile = tempNodeConf.Name()
 	warewulfd.SetNoDaemon()
 	for _, tt := range tests {
-		_, err = node.TestNew([]byte(tt.inDb))
+		var err error
+		_, err = tempNodeConf.Seek(0, 0)
 		assert.NoError(t, err)
+		assert.NoError(t, tempNodeConf.Truncate(0))
+		_, err = tempNodeConf.Write([]byte(tt.inDb))
+		assert.NoError(t, tempNodeConf.Sync())
 		t.Logf("Running test: %s\n", tt.name)
 		t.Run(tt.name, func(t *testing.T) {
 			baseCmd := GetCommand()

internal/app/wwctl/profile/list/main_test.go

@@ -36,16 +36,27 @@ nodes:
 		},
 	}
 
-	conf_yml := `
-WW_INTERNAL: 0
-    `
+	conf_yml := `WW_INTERNAL: 0`
+	tempWarewulfConf, warewulfConfErr := os.CreateTemp("", "warewulf.conf-")
+	assert.NoError(t, warewulfConfErr)
+	defer os.Remove(tempWarewulfConf.Name())
+	_, warewulfConfErr = tempWarewulfConf.Write([]byte(conf_yml))
+	assert.NoError(t, warewulfConfErr)
+	assert.NoError(t, tempWarewulfConf.Sync())
+	warewulfconf.ConfigFile = tempWarewulfConf.Name()
 
-	conf := warewulfconf.New()
-	err := conf.Read([]byte(conf_yml))
-	assert.NoError(t, err)
+	tempNodeConf, nodesConfErr := os.CreateTemp("", "nodes.conf-")
+	assert.NoError(t, nodesConfErr)
+	defer os.Remove(tempNodeConf.Name())
+	node.ConfigFile = tempNodeConf.Name()
 	warewulfd.SetNoDaemon()
 	for _, tt := range tests {
-		_, err = node.TestNew([]byte(tt.inDb))
+		var err error
+		_, err = tempNodeConf.Seek(0, 0)
+		assert.NoError(t, err)
+		assert.NoError(t, tempNodeConf.Truncate(0))
+		_, err = tempNodeConf.Write([]byte(tt.inDb))
+		assert.NoError(t, tempNodeConf.Sync())
 		assert.NoError(t, err)
 		t.Logf("Running test: %s\n", tt.name)
 		t.Run(tt.name, func(t *testing.T) {