From 455d9b65e4941206d250ab7d32d5d2000d99e4c3 Mon Sep 17 00:00:00 2001 From: Christian Goll Date: Wed, 15 Jan 2025 10:20:08 +0100 Subject: [PATCH] Fix panic ObjectIsEmpty for bool Signed-off-by: Christian Goll --- CHANGELOG.md | 1 + internal/pkg/node/util.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3d091b3a..fbb8fd99 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -135,6 +135,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Format errors in logs as strings. #1563 - Fix display of profiles during node list. #1496 - Fix internal DelProfile function to correctly operate on profiles rather than nodes. #1622 +- Fix parsing of bool command line variables #1627 ## v4.5.8, 2024-10-01 diff --git a/internal/pkg/node/util.go b/internal/pkg/node/util.go index 478e55a4..d0d2d271 100644 --- a/internal/pkg/node/util.go +++ b/internal/pkg/node/util.go @@ -66,7 +66,7 @@ func ObjectIsEmpty(obj interface{}) bool { } for i := 0; i < varType.NumField(); i++ { if varType.Field(i).Type.Kind() == reflect.String && !varVal.Field(i).IsZero() { - val := varVal.Field(i).Interface().(string) + val := varVal.Field(i).String() if val != "" { return false }