kelvin/warewulf
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Address copilot review from #1945

Browse Source 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
This commit is contained in:
Jonathon Anderson
2025-07-28 18:57:01 -06:00
parent 5ceeb60c24
commit 7d0b73e452
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/pkg/overlay/overlay.go
View File

@@ -66,7 +66,7 @@ func (overlay Overlay) Rootfs() string {
//
// Returns:
// - The full path to the specified file in the overlay's rootfs.
// If the specified path does not exist in the overlay, the empty string is returned.
// If the specified path is not contained within the overlay, the empty string is returned.
func (overlay Overlay) File(filePath string) string {
rootfs := overlay.Rootfs()
fullPath := path.Join(rootfs, filePath)
@@ -122,7 +122,7 @@ func (overlay Overlay) AddFile(filePath string, content []byte, parents bool, fo
if err != nil {
return fmt.Errorf("failed to clone distribution overlay '%s' to site overlay: %w", overlay.Name(), err)
}
// replace the overlay with newly creatd siteOverlay
// replace the overlay with newly created siteOverlay
overlay = siteOverlay
}
@@ -168,7 +168,7 @@ func (overlay Overlay) DeleteFile(filePath string, force, cleanup bool) error {
if err != nil {
return fmt.Errorf("failed to clone distribution overlay '%s' to site overlay: %w", overlay.Name(), err)
}
// replace the overlay with newly creatd siteOverlay
// replace the overlay with newly created siteOverlay
overlay = siteOverlay
}

3
internal/pkg/warewulfd/api/overlay.go
View File

@@ -302,9 +302,6 @@ func addOverlayFile() usecase.Interactor {
if input.Path == "" {
return status.Wrap(fmt.Errorf("must specify a path"), status.InvalidArgument)
}
if input.Content == "" {
return status.Wrap(fmt.Errorf("content should not be empty"), status.InvalidArgument)
}
if relPath, err := url.QueryUnescape(input.Path); err != nil {
return fmt.Errorf("failed to decode path: %v: %w", input.Path, err)
} else {