Refactor kernel support
- Remove kernel imports and kmods images - Repurpose KernelOverride as container path - Support Kernel.Version as version prefix for kernel selection - Compare initramfs by version Signed-off-by: Jonathon Anderson <janderson@ciq.com>
This commit is contained in:
Jonathon Anderson
committed by
Christian Goll
Christian Goll
parent
d87ed27d8d
commit
8f21d54243
@@ -1,333 +1,150 @@
|
||||
package kernel
|
||||
|
||||
import (
|
||||
"compress/gzip"
|
||||
"fmt"
|
||||
"io"
|
||||
"os"
|
||||
"path"
|
||||
"path/filepath"
|
||||
"regexp"
|
||||
"sort"
|
||||
"strings"
|
||||
|
||||
"github.com/pkg/errors"
|
||||
|
||||
"github.com/hashicorp/go-version"
|
||||
warewulfconf "github.com/warewulf/warewulf/internal/pkg/config"
|
||||
|
||||
"github.com/warewulf/warewulf/internal/pkg/container"
|
||||
"github.com/warewulf/warewulf/internal/pkg/node"
|
||||
"github.com/warewulf/warewulf/internal/pkg/util"
|
||||
"github.com/warewulf/warewulf/internal/pkg/wwlog"
|
||||
)
|
||||
|
||||
var (
|
||||
kernelSearchPaths = []string{
|
||||
// This is a printf format where the %s will be the kernel version
|
||||
"/boot/Image-%s", // this is the aarch64 for SUSE, vmlinux which is also present won't boot
|
||||
"/boot/vmlinuz-linux%s",
|
||||
"/boot/vmlinuz-%s",
|
||||
"/boot/vmlinuz-%s.gz",
|
||||
"/lib/modules/%s/vmlinuz",
|
||||
"/lib/modules/%s/vmlinuz.gz",
|
||||
"/boot/Image-*", // this is the aarch64 for SUSE, vmlinux which is also present won't boot
|
||||
"/boot/vmlinuz-linux*",
|
||||
"/boot/vmlinuz-*",
|
||||
"/lib/modules/*/vmlinuz",
|
||||
"/lib/modules/*/vmlinuz.gz",
|
||||
}
|
||||
kernelDrivers = []string{
|
||||
"lib/modules/%s/*",
|
||||
"lib/firmware/*",
|
||||
"lib/modprobe.d",
|
||||
"lib/modules-load.d"}
|
||||
// kenrel naming convention <base kernel version>-<ABI number>.<upload number>-<flavour>
|
||||
kernelVersionRegex = `(\d+\.\d+\.\d+)-((\d+\.*){1,})`
|
||||
)
|
||||
|
||||
func KernelImageTopDir() string {
|
||||
conf := warewulfconf.Get()
|
||||
return path.Join(conf.Paths.WWProvisiondir, "kernel")
|
||||
type collection []*Kernel
|
||||
|
||||
func (k collection) Len() int {
|
||||
return len(k)
|
||||
}
|
||||
|
||||
func KernelImage(kernelName string) string {
|
||||
if kernelName == "" {
|
||||
wwlog.Error("Kernel Name is not defined")
|
||||
return ""
|
||||
}
|
||||
|
||||
if !util.ValidString(kernelName, "^[a-zA-Z0-9-._]+$") {
|
||||
wwlog.Error("Runtime overlay name contains illegal characters: %s", kernelName)
|
||||
return ""
|
||||
}
|
||||
|
||||
return path.Join(KernelImageTopDir(), kernelName, "vmlinuz")
|
||||
func (k collection) Less(i, j int) bool {
|
||||
iv := k[i].version()
|
||||
jv := k[j].version()
|
||||
return (iv == nil && jv != nil) ||
|
||||
(iv != nil && jv != nil && iv.LessThan(jv))
|
||||
}
|
||||
|
||||
func GetKernelVersion(kernelName string) string {
|
||||
if kernelName == "" {
|
||||
wwlog.Error("Kernel Name is not defined")
|
||||
return ""
|
||||
}
|
||||
kernelVersion, err := os.ReadFile(KernelVersionFile(kernelName))
|
||||
if err != nil {
|
||||
return ""
|
||||
}
|
||||
return string(kernelVersion)
|
||||
func (k collection) Swap(i, j int) {
|
||||
k[i], k[j] = k[j], k[i]
|
||||
}
|
||||
|
||||
func KmodsImage(kernelName string) string {
|
||||
if kernelName == "" {
|
||||
wwlog.Error("Kernel Name is not defined")
|
||||
return ""
|
||||
}
|
||||
|
||||
if !util.ValidString(kernelName, "^[a-zA-Z0-9-._]+$") {
|
||||
wwlog.Error("Runtime overlay name contains illegal characters: %s", kernelName)
|
||||
return ""
|
||||
}
|
||||
|
||||
return path.Join(KernelImageTopDir(), kernelName, "kmods.img")
|
||||
func (k collection) Sort() {
|
||||
sort.Sort(k)
|
||||
}
|
||||
|
||||
func KernelVersionFile(kernelName string) string {
|
||||
if kernelName == "" {
|
||||
wwlog.Error("Kernel Name is not defined")
|
||||
return ""
|
||||
}
|
||||
|
||||
if !util.ValidString(kernelName, "^[a-zA-Z0-9-._]+$") {
|
||||
wwlog.Error("Runtime overlay name contains illegal characters: %s", kernelName)
|
||||
return ""
|
||||
}
|
||||
|
||||
return path.Join(KernelImageTopDir(), kernelName, "version")
|
||||
}
|
||||
|
||||
func ListKernels() ([]string, error) {
|
||||
var ret []string
|
||||
|
||||
err := os.MkdirAll(KernelImageTopDir(), 0755)
|
||||
if err != nil {
|
||||
return ret, errors.New("Could not create Kernel parent directory: " + KernelImageTopDir())
|
||||
}
|
||||
|
||||
wwlog.Debug("Searching for Kernel image directories: %s", KernelImageTopDir())
|
||||
|
||||
kernels, err := os.ReadDir(KernelImageTopDir())
|
||||
if err != nil {
|
||||
return ret, err
|
||||
}
|
||||
|
||||
for _, kernel := range kernels {
|
||||
wwlog.Verbose("Found Kernel: %s", kernel.Name())
|
||||
|
||||
ret = append(ret, kernel.Name())
|
||||
|
||||
}
|
||||
|
||||
return ret, nil
|
||||
}
|
||||
|
||||
/*
|
||||
Triggers the kernel extraction and build of the modules for the given
|
||||
kernel version. A name for this kernel and were to find has also to be
|
||||
supplied
|
||||
*/
|
||||
func Build(kernelVersion, kernelName, root string) error {
|
||||
kernelDestination := KernelImage(kernelName)
|
||||
driversDestination := KmodsImage(kernelName)
|
||||
versionDestination := KernelVersionFile(kernelName)
|
||||
|
||||
// Create the destination paths just in case it doesn't exist
|
||||
err := os.MkdirAll(path.Dir(kernelDestination), 0755)
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to create kernel dest: %w", err)
|
||||
}
|
||||
|
||||
err = os.MkdirAll(path.Dir(driversDestination), 0755)
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to create driver dest: %w", err)
|
||||
}
|
||||
|
||||
err = os.MkdirAll(path.Dir(versionDestination), 0755)
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to create version dest: %s", err)
|
||||
}
|
||||
|
||||
kernelSource, kernelVersFound, err := FindKernel(root)
|
||||
if err != nil {
|
||||
return err
|
||||
} else if kernelVersFound != kernelVersion {
|
||||
return fmt.Errorf("requested %s and found kernel version %s differ", kernelVersion, kernelVersFound)
|
||||
} else {
|
||||
wwlog.Info("Found kernel at: %s", kernelSource)
|
||||
}
|
||||
|
||||
wwlog.Verbose("Setting up Kernel")
|
||||
if _, err := os.Stat(kernelSource); err == nil {
|
||||
kernel, err := os.Open(kernelSource)
|
||||
if err != nil {
|
||||
return fmt.Errorf("could not open kernel: %w", err)
|
||||
func (k collection) Preferred() *Kernel {
|
||||
nk := append(collection{}, k...)
|
||||
sort.Sort(sort.Reverse(nk))
|
||||
for _, kernel := range nk {
|
||||
if !(kernel.IsDebug() || kernel.IsRescue()) {
|
||||
return kernel
|
||||
}
|
||||
defer kernel.Close()
|
||||
|
||||
gzipreader, err := gzip.NewReader(kernel)
|
||||
if err == nil {
|
||||
defer gzipreader.Close()
|
||||
|
||||
writer, err := os.Create(kernelDestination)
|
||||
if err != nil {
|
||||
return fmt.Errorf("could not decompress kernel: %w", err)
|
||||
}
|
||||
defer writer.Close()
|
||||
|
||||
_, err = io.Copy(writer, gzipreader)
|
||||
if err != nil {
|
||||
return fmt.Errorf("could not write decompressed kernel: %w", err)
|
||||
}
|
||||
|
||||
} else {
|
||||
|
||||
err := util.CopyFile(kernelSource, kernelDestination)
|
||||
if err != nil {
|
||||
return fmt.Errorf("could not copy kernel: %w", err)
|
||||
}
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
name := kernelName + " drivers"
|
||||
var kernelDriversSpecific []string
|
||||
for _, kPath := range kernelDrivers {
|
||||
if strings.Contains(kPath, "%s") {
|
||||
kernelDriversSpecific = append(kernelDriversSpecific, fmt.Sprintf(kPath, kernelVersion))
|
||||
} else {
|
||||
kernelDriversSpecific = append(kernelDriversSpecific, kPath)
|
||||
}
|
||||
}
|
||||
wwlog.Debug("kernelDriversSpecific: %v", kernelDriversSpecific)
|
||||
wwlog.Verbose("Creating image for %s: %s", name, root)
|
||||
err = util.BuildFsImage(
|
||||
name,
|
||||
root,
|
||||
driversDestination,
|
||||
kernelDriversSpecific,
|
||||
[]string{},
|
||||
// ignore cross-device files
|
||||
true,
|
||||
"newc",
|
||||
// dereference symbolic links
|
||||
"-L")
|
||||
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
wwlog.Verbose("Creating version file")
|
||||
file, err := os.Create(versionDestination)
|
||||
if err != nil {
|
||||
return fmt.Errorf("Failed to create version file: %w", err)
|
||||
}
|
||||
defer file.Close()
|
||||
_, err = io.WriteString(file, kernelVersion)
|
||||
if err != nil {
|
||||
return fmt.Errorf("Could not write kernel version: %w", err)
|
||||
}
|
||||
err = file.Sync()
|
||||
if err != nil {
|
||||
return fmt.Errorf("Could not sync kernel version: %w", err)
|
||||
}
|
||||
return nil
|
||||
}
|
||||
|
||||
func DeleteKernel(name string) error {
|
||||
fullPath := path.Join(KernelImageTopDir(), name)
|
||||
|
||||
wwlog.Verbose("Removing path: %s", fullPath)
|
||||
return os.RemoveAll(fullPath)
|
||||
}
|
||||
|
||||
/*
|
||||
Searches for kernel under a given path. First return result is the
|
||||
full path, second the version and an error if the kernel couldn't be found.
|
||||
*/
|
||||
type kernel struct {
|
||||
version string
|
||||
path string
|
||||
}
|
||||
|
||||
func filter(val string, filters []func(string) (string, error)) (string, error) {
|
||||
for _, ft := range filters {
|
||||
newVal, err := ft(val)
|
||||
if err != nil {
|
||||
return val, err
|
||||
}
|
||||
val = newVal
|
||||
}
|
||||
return val, nil
|
||||
}
|
||||
|
||||
func nonDebugKernel(val string) (string, error) {
|
||||
if strings.HasSuffix(val, "+debug") {
|
||||
return val, fmt.Errorf("%s is debug kernel, skipped", val)
|
||||
}
|
||||
return val, nil
|
||||
}
|
||||
|
||||
func nonSemaVer(val string) (string, error) {
|
||||
// need to extract version info
|
||||
verRegx := regexp.MustCompile(kernelVersionRegex)
|
||||
verRe := verRegx.FindAllStringSubmatch(val, -1)
|
||||
// only if at the least the following pattern is matched <xx.xx.xx>-<xx[.xx.xx]>
|
||||
if len(verRe) > 0 && len(verRe[0]) > 2 {
|
||||
// verRe[0][1] -> <xx.xx.xx>
|
||||
// verRe[0][2] -> <xx[.xx.xx]>
|
||||
verStr := strings.TrimSuffix(fmt.Sprintf("%s-%s", verRe[0][1], verRe[0][2]), ".")
|
||||
_, err := version.NewVersion(verStr)
|
||||
if err != nil {
|
||||
return val, fmt.Errorf("semantic incompatible version detected, version string: %s, err: %s", verStr, err)
|
||||
}
|
||||
return verStr, nil
|
||||
}
|
||||
return val, fmt.Errorf("unable to extract version info from %s", val)
|
||||
}
|
||||
|
||||
func FindKernel(root string) (string, string, error) {
|
||||
wwlog.Debug("root: %s", root)
|
||||
for _, searchPath := range kernelSearchPaths {
|
||||
testPattern := fmt.Sprintf(path.Join(root, searchPath), `*`)
|
||||
wwlog.Debug("Looking for kernel version with pattern at: %s", testPattern)
|
||||
potentialKernel, _ := filepath.Glob(testPattern)
|
||||
if len(potentialKernel) == 0 {
|
||||
func (k collection) Version(version string) *Kernel {
|
||||
for _, kernel := range k {
|
||||
if kernel.IsDebug() || kernel.IsRescue() {
|
||||
continue
|
||||
}
|
||||
|
||||
verMap := make(map[*version.Version]*kernel, len(potentialKernel))
|
||||
for _, foundKernel := range potentialKernel {
|
||||
wwlog.Debug("Parsing out kernel version for %s", foundKernel)
|
||||
re := regexp.MustCompile(fmt.Sprintf(path.Join(root, searchPath), `([\w\d-\.+]*)`))
|
||||
kernelVer := re.FindAllStringSubmatch(foundKernel, -1)
|
||||
if kernelVer == nil {
|
||||
break
|
||||
}
|
||||
// kernelVerStr is like 5.14.0-427.18.1.el9_4.x86_64
|
||||
kernelVerStr := strings.TrimSuffix(kernelVer[0][1], ".gz")
|
||||
|
||||
newVal, err := filter(kernelVerStr, []func(string) (string, error){nonDebugKernel, nonSemaVer})
|
||||
if err != nil {
|
||||
wwlog.Verbose("While filtering kernel version for %s, having error: %s", kernelVerStr, err)
|
||||
continue
|
||||
}
|
||||
ver, _ := version.NewVersion(newVal)
|
||||
verMap[ver] = &kernel{
|
||||
version: kernelVerStr,
|
||||
path: foundKernel,
|
||||
}
|
||||
}
|
||||
|
||||
if len(verMap) > 0 {
|
||||
var keys []*version.Version
|
||||
for k := range verMap {
|
||||
keys = append(keys, k)
|
||||
}
|
||||
sort.Sort(sort.Reverse(version.Collection(keys)))
|
||||
return verMap[keys[0]].path, verMap[keys[0]].version, nil
|
||||
} else if strings.HasPrefix(kernel.Version(), version) {
|
||||
return kernel
|
||||
}
|
||||
}
|
||||
return "", "", fmt.Errorf("could not find kernel version")
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
type Kernel struct {
|
||||
Path string
|
||||
ContainerName string
|
||||
}
|
||||
|
||||
func FromNode(node *node.Node) *Kernel {
|
||||
wwlog.Debug("FromNode(%v)", node)
|
||||
if node.ContainerName == "" {
|
||||
return nil
|
||||
} else if node.Kernel.Override != "" {
|
||||
return &Kernel{ContainerName: node.ContainerName, Path: filepath.Join("/", node.Kernel.Override)}
|
||||
} else if node.Kernel.Version != "" {
|
||||
return FindKernels(node.ContainerName).Version(node.Kernel.Version)
|
||||
} else {
|
||||
return FindKernels(node.ContainerName).Preferred()
|
||||
}
|
||||
}
|
||||
|
||||
func FindKernelsFromPattern(containerName string, pattern string) (kernels collection) {
|
||||
wwlog.Debug("FindKernelsFromPattern(%v, %v)", containerName, pattern)
|
||||
root := container.RootFsDir(containerName)
|
||||
fullPaths, err := filepath.Glob(filepath.Join(root, pattern))
|
||||
wwlog.Debug("%v: fullPaths: %v", filepath.Join(root, pattern), fullPaths)
|
||||
if err != nil {
|
||||
panic(err)
|
||||
}
|
||||
for _, fullPath := range fullPaths {
|
||||
path, err := filepath.Rel(root, fullPath)
|
||||
if err != nil {
|
||||
continue
|
||||
} else {
|
||||
kernels = append(kernels, &Kernel{ContainerName: containerName, Path: filepath.Join("/", path)})
|
||||
}
|
||||
}
|
||||
return kernels
|
||||
}
|
||||
|
||||
func FindKernels(containerName string) (kernels collection) {
|
||||
wwlog.Debug("FindKernels(%v)", containerName)
|
||||
for _, pattern := range kernelSearchPaths {
|
||||
kernels = append(kernels, FindKernelsFromPattern(containerName, pattern)...)
|
||||
}
|
||||
return kernels
|
||||
}
|
||||
|
||||
func FindAllKernels() (kernels collection) {
|
||||
wwlog.Debug("FindAllKernels()")
|
||||
if sources, err := container.ListSources(); err == nil {
|
||||
for _, source := range sources {
|
||||
kernels = append(kernels, FindKernels(source)...)
|
||||
}
|
||||
} else {
|
||||
wwlog.Error("%s", err)
|
||||
}
|
||||
return kernels
|
||||
}
|
||||
|
||||
func (this *Kernel) version() *version.Version {
|
||||
return util.ParseVersion(this.Path)
|
||||
}
|
||||
|
||||
func (this *Kernel) Version() string {
|
||||
version := this.version()
|
||||
if version == nil {
|
||||
return ""
|
||||
} else {
|
||||
return version.String()
|
||||
}
|
||||
}
|
||||
|
||||
func (this *Kernel) IsDebug() bool {
|
||||
return strings.Contains(this.Path, "+debug")
|
||||
}
|
||||
|
||||
func (this *Kernel) IsRescue() bool {
|
||||
return strings.Contains(this.Path, "-rescue")
|
||||
}
|
||||
|
||||
func (this *Kernel) FullPath() string {
|
||||
root := container.RootFsDir(this.ContainerName)
|
||||
return filepath.Join(root, this.Path)
|
||||
}
|
||||
|
||||
@@ -1,168 +1,236 @@
|
||||
package kernel
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"os"
|
||||
"path"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
warewulfconf "github.com/warewulf/warewulf/internal/pkg/config"
|
||||
"github.com/warewulf/warewulf/internal/pkg/util"
|
||||
"github.com/warewulf/warewulf/internal/pkg/wwlog"
|
||||
|
||||
"github.com/warewulf/warewulf/internal/pkg/node"
|
||||
"github.com/warewulf/warewulf/internal/pkg/testenv"
|
||||
)
|
||||
|
||||
var kernelBuildTests = []struct {
|
||||
kernelVersion string
|
||||
kernelName string
|
||||
kernelFileName string
|
||||
succeed bool
|
||||
}{
|
||||
// kernel naming convention is <base kernel version>-<ABI number>.<upload number>-<flavour>
|
||||
{"4.3.2-1", "kernel1", "vmlinuz-1.2.3-4.gz", false},
|
||||
{"1.2.3-4", "kernel1", "vmlinuz-1.2.3-4.gz", true},
|
||||
{"1.2.3-4.3.1-generic", "kernel1", "vmlinuz-1.2.3-4.3.1-generic.gz", true},
|
||||
}
|
||||
|
||||
func Test_BuildKernel(t *testing.T) {
|
||||
wwlog.SetLogLevel(wwlog.DEBUG)
|
||||
for _, tt := range kernelBuildTests {
|
||||
srvDir, err := os.MkdirTemp(os.TempDir(), "ww-test-srv-*")
|
||||
assert.NoError(t, err)
|
||||
conf := warewulfconf.Get()
|
||||
conf.Paths.WWProvisiondir = srvDir
|
||||
kernelDir, err := os.MkdirTemp(os.TempDir(), "ww-test-kernel-*")
|
||||
assert.NoError(t, err)
|
||||
{
|
||||
err = os.MkdirAll(path.Join(kernelDir, "boot"), 0755)
|
||||
assert.NoError(t, err)
|
||||
err = os.MkdirAll(path.Join(kernelDir, "lib/modules/old-kernel"), 0755)
|
||||
assert.NoError(t, err)
|
||||
_, err = os.Create(path.Join(kernelDir, "lib/modules/old-kernel/old-module"))
|
||||
assert.NoError(t, err)
|
||||
err = os.MkdirAll(path.Join(kernelDir, "lib/firmware"), 0755)
|
||||
assert.NoError(t, err)
|
||||
_, err = os.Create(path.Join(kernelDir, "lib/firmware/test-firmware"))
|
||||
assert.NoError(t, err)
|
||||
_, err = os.Create(path.Join(kernelDir, "boot", tt.kernelFileName))
|
||||
assert.NoError(t, err)
|
||||
err = os.MkdirAll(path.Join(kernelDir, "lib/modules", tt.kernelVersion, "/nested"), 0755)
|
||||
assert.NoError(t, err)
|
||||
_, err = os.Create(path.Join(kernelDir, "lib/modules", tt.kernelVersion, "test-module"))
|
||||
assert.NoError(t, err)
|
||||
err = os.Symlink(path.Join(kernelDir, "lib/modules/old-kernel/old-module"), path.Join(kernelDir, "lib/modules", tt.kernelVersion, "symlink-module"))
|
||||
assert.NoError(t, err)
|
||||
}
|
||||
t.Run(tt.kernelName, func(t *testing.T) {
|
||||
err = Build(tt.kernelVersion, tt.kernelName, kernelDir)
|
||||
if tt.succeed {
|
||||
assert.NoError(t, err)
|
||||
assert.FileExists(t, path.Join(srvDir, "kernel", tt.kernelName, "vmlinuz"))
|
||||
assert.FileExists(t, path.Join(srvDir, "kernel", tt.kernelName, "kmods.img.gz"))
|
||||
assert.FileExists(t, path.Join(srvDir, "kernel", tt.kernelName, "kmods.img"))
|
||||
files, err := util.CpioFiles(path.Join(srvDir, "kernel", tt.kernelName, "kmods.img"))
|
||||
assert.NoError(t, err)
|
||||
assert.ElementsMatch(t, files, []string{
|
||||
"lib/firmware/test-firmware",
|
||||
"lib/modules/" + tt.kernelVersion + "/symlink-module",
|
||||
"lib/modules/" + tt.kernelVersion + "/test-module",
|
||||
"lib/modules/" + tt.kernelVersion + "/nested"})
|
||||
} else {
|
||||
assert.Error(t, err)
|
||||
}
|
||||
})
|
||||
os.RemoveAll(srvDir)
|
||||
os.RemoveAll(kernelDir)
|
||||
}
|
||||
}
|
||||
|
||||
var kernelFindTests = []struct {
|
||||
name string
|
||||
prefix string // kernel name prefix
|
||||
kernelNames []string
|
||||
expVer string
|
||||
expPath string
|
||||
}{
|
||||
{
|
||||
name: "vmlinuz under boot directory ok case",
|
||||
prefix: "/boot/vmlinuz-%s",
|
||||
kernelNames: []string{"5.14.0-427.18.1.el9_4.x86_64", "5.14.0-427.24.1.el9_4.x86_64", "4.14.0-427.18.1.el8_4.x86_64"},
|
||||
expVer: "5.14.0-427.24.1.el9_4.x86_64",
|
||||
expPath: "/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
},
|
||||
{
|
||||
name: "vmlinuz under boot directory ok case 2",
|
||||
prefix: "/boot/vmlinuz-%s",
|
||||
kernelNames: []string{"5.15.0-119-generic", "5.14.0-427.24.1.el9_4.x86_64", "6.15.0-119-generic"},
|
||||
expVer: "6.15.0-119-generic",
|
||||
expPath: "/boot/vmlinuz-6.15.0-119-generic",
|
||||
},
|
||||
{
|
||||
name: "vmlinuz under boot directory ok case 3",
|
||||
prefix: "/boot/vmlinuz-%s",
|
||||
kernelNames: []string{"5.15.0-0-vanilla", "5.14.0-427.24.1.el9_4.x86_64"},
|
||||
expVer: "5.15.0-0-vanilla",
|
||||
expPath: "/boot/vmlinuz-5.15.0-0-vanilla",
|
||||
},
|
||||
{
|
||||
// <base kernel version>-<ABI number>.<upload number>-<flavour>
|
||||
name: "vmlinuz under boot directory ok case (becuase the first version naming is incorrect)",
|
||||
prefix: "/boot/vmlinuz-%s",
|
||||
kernelNames: []string{"5.15.0-generic", "5.14.0-427.24.1.el9_4.x86_64", "5.13.0-427.24.1.el9_4.x86_64"},
|
||||
expVer: "5.14.0-427.24.1.el9_4.x86_64",
|
||||
expPath: "/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
},
|
||||
{
|
||||
name: "vmlinuz under lib modules ok case",
|
||||
prefix: "/lib/modules/%s/vmlinuz",
|
||||
kernelNames: []string{"5.14.0-427.18.1.el9_4.x86_64", "5.14.0-427.24.1.el9_4.x86_64"},
|
||||
expVer: "5.14.0-427.24.1.el9_4.x86_64",
|
||||
expPath: "/lib/modules/5.14.0-427.24.1.el9_4.x86_64/vmlinuz",
|
||||
},
|
||||
{
|
||||
name: "vmlinuz.gz under boot directory ok case",
|
||||
prefix: "/boot/vmlinuz-%s.gz",
|
||||
kernelNames: []string{"5.14.0-427.18.1.el9_4.x86_64", "5.14.0-427.24.1.el9_4.x86_64"},
|
||||
expVer: "5.14.0-427.24.1.el9_4.x86_64",
|
||||
expPath: "/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64.gz",
|
||||
},
|
||||
{
|
||||
name: "mixed rescue / debug kernel testing",
|
||||
prefix: "/boot/vmlinuz-%s",
|
||||
kernelNames: []string{"0-rescue-eb46964329b146e39518c625feab3ea0", "5.14.0-362.24.1.el9_3.aarch64", "5.14.0-427.31.1.el9_4.aarch64+debug", "5.14.0-284.30.1.el9_2.aarch64", "5.14.0-427.31.1.el9_4.aarch64"},
|
||||
expVer: "5.14.0-427.31.1.el9_4.aarch64",
|
||||
expPath: "/boot/vmlinuz-5.14.0-427.31.1.el9_4.aarch64",
|
||||
},
|
||||
}
|
||||
|
||||
func Test_FindKernel(t *testing.T) {
|
||||
wwlog.SetLogLevel(wwlog.DEBUG)
|
||||
for _, tt := range kernelFindTests {
|
||||
srvDir, err := os.MkdirTemp(os.TempDir(), "ww-test-srv-*")
|
||||
assert.NoError(t, err)
|
||||
conf := warewulfconf.Get()
|
||||
conf.Paths.WWProvisiondir = srvDir
|
||||
kernelDir, err := os.MkdirTemp(os.TempDir(), "ww-test-kernel-*")
|
||||
assert.NoError(t, err)
|
||||
{
|
||||
for _, version := range tt.kernelNames {
|
||||
kernel := fmt.Sprintf(tt.prefix, version)
|
||||
parent := filepath.Dir(kernel)
|
||||
err = os.MkdirAll(path.Join(kernelDir, parent), 0755)
|
||||
assert.NoError(t, err)
|
||||
_, err := os.Create(path.Join(kernelDir, kernel))
|
||||
assert.NoError(t, err)
|
||||
}
|
||||
}
|
||||
var tests = map[string]struct {
|
||||
files []string
|
||||
version string
|
||||
path string
|
||||
}{
|
||||
"/boot/vmlinuz-* (1)": {
|
||||
files: []string{
|
||||
"/boot/vmlinuz-5.14.0-427.18.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-4.14.0-427.18.1.el8_4.x86_64",
|
||||
},
|
||||
version: "5.14.0-427.24.1",
|
||||
path: "/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
},
|
||||
"/boot/vmlinuz-* (2)": {
|
||||
files: []string{
|
||||
"/boot/vmlinuz-5.15.0-119-generic",
|
||||
"/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-6.15.0-119-generic",
|
||||
},
|
||||
version: "6.15.0-119",
|
||||
path: "/boot/vmlinuz-6.15.0-119-generic",
|
||||
},
|
||||
"/boot/vmlinuz-* (3)": {
|
||||
files: []string{
|
||||
"/boot/vmlinuz-5.15.0-0-vanilla",
|
||||
"/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
},
|
||||
version: "5.15.0-0",
|
||||
path: "/boot/vmlinuz-5.15.0-0-vanilla",
|
||||
},
|
||||
"/boot/vmlinuz-* (4)": {
|
||||
files: []string{
|
||||
"/boot/vmlinuz-5.15.0-generic",
|
||||
"/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-5.13.0-427.24.1.el9_4.x86_64",
|
||||
},
|
||||
version: "5.15.0",
|
||||
path: "/boot/vmlinuz-5.15.0-generic",
|
||||
},
|
||||
"/lib/modules/*/vmlinuz": {
|
||||
files: []string{
|
||||
"/lib/modules/5.14.0-427.18.1.el9_4.x86_64/vmlinuz",
|
||||
"/lib/modules/5.14.0-427.24.1.el9_4.x86_64/vmlinuz",
|
||||
},
|
||||
version: "5.14.0-427.24.1",
|
||||
path: "/lib/modules/5.14.0-427.24.1.el9_4.x86_64/vmlinuz",
|
||||
},
|
||||
"/boot/vmlinuz-*.gz": {
|
||||
files: []string{
|
||||
"/boot/vmlinuz-5.14.0-427.18.1.el9_4.x86_64.gz",
|
||||
"/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64.gz",
|
||||
},
|
||||
version: "5.14.0-427.24.1",
|
||||
path: "/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64.gz",
|
||||
},
|
||||
"ignore rescue and debug kernels": {
|
||||
files: []string{
|
||||
"/boot/vmlinuz-0-rescue-eb46964329b146e39518c625feab3ea0",
|
||||
"/boot/vmlinuz-5.14.0-362.24.1.el9_3.aarch64",
|
||||
"/boot/vmlinuz-5.14.0-427.31.1.el9_4.aarch64+debug",
|
||||
"/boot/vmlinuz-5.14.0-284.30.1.el9_2.aarch64",
|
||||
"/boot/vmlinuz-5.14.0-427.31.1.el9_4.aarch64",
|
||||
},
|
||||
version: "5.14.0-427.31.1",
|
||||
path: "/boot/vmlinuz-5.14.0-427.31.1.el9_4.aarch64",
|
||||
},
|
||||
"no kernels": {
|
||||
files: []string{},
|
||||
version: "",
|
||||
path: "",
|
||||
},
|
||||
}
|
||||
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
kpath, kver, err := FindKernel(kernelDir)
|
||||
assert.NoError(t, err)
|
||||
assert.Equal(t, tt.expVer, kver)
|
||||
assert.Equal(t, filepath.Join(kernelDir, tt.expPath), kpath)
|
||||
for name, tt := range tests {
|
||||
t.Run(name, func(t *testing.T) {
|
||||
env := testenv.New(t)
|
||||
defer env.RemoveAll(t)
|
||||
rootfs := "/var/lib/warewulf/chroots/testcontainer/rootfs"
|
||||
for _, file := range tt.files {
|
||||
env.CreateFile(t, filepath.Join(rootfs, file))
|
||||
}
|
||||
|
||||
kernels := FindKernels("testcontainer")
|
||||
assert.Equal(t, len(tt.files), len(kernels))
|
||||
kernel := kernels.Preferred()
|
||||
if tt.version == "" && tt.path == "" {
|
||||
assert.Nil(t, kernel)
|
||||
} else {
|
||||
assert.Equal(t, "testcontainer", kernel.ContainerName)
|
||||
assert.Equal(t, tt.version, kernel.Version())
|
||||
assert.Equal(t, tt.path, kernel.Path)
|
||||
assert.Equal(t, env.GetPath(filepath.Join(rootfs, tt.path)), kernel.FullPath())
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func Test_FromNode(t *testing.T) {
|
||||
tests := map[string]struct {
|
||||
files []string
|
||||
override string
|
||||
path string
|
||||
}{
|
||||
"default": {
|
||||
files: []string{
|
||||
"/boot/vmlinuz-5.14.0-427.18.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-4.14.0-427.18.1.el8_4.x86_64",
|
||||
},
|
||||
override: "",
|
||||
path: "/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
},
|
||||
"override": {
|
||||
files: []string{
|
||||
"/boot/vmlinuz-5.14.0-427.18.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-4.14.0-427.18.1.el8_4.x86_64",
|
||||
},
|
||||
override: "/boot/vmlinuz-4.14.0-427.18.1.el8_4.x86_64",
|
||||
path: "/boot/vmlinuz-4.14.0-427.18.1.el8_4.x86_64",
|
||||
},
|
||||
"none": {
|
||||
files: []string{},
|
||||
override: "",
|
||||
path: "",
|
||||
},
|
||||
}
|
||||
for name, tt := range tests {
|
||||
t.Run(name, func(t *testing.T) {
|
||||
env := testenv.New(t)
|
||||
defer env.RemoveAll(t)
|
||||
rootfs := "/var/lib/warewulf/chroots/testcontainer/rootfs"
|
||||
for _, file := range tt.files {
|
||||
env.CreateFile(t, filepath.Join(rootfs, file))
|
||||
}
|
||||
node := node.EmptyNode()
|
||||
node.ContainerName = "testcontainer"
|
||||
node.Kernel.Override = tt.override
|
||||
kernel := FromNode(&node)
|
||||
if tt.path == "" {
|
||||
assert.Nil(t, kernel)
|
||||
} else {
|
||||
assert.Equal(t, "testcontainer", kernel.ContainerName)
|
||||
assert.Equal(t, tt.path, kernel.Path)
|
||||
}
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func Test_FindAllKernels(t *testing.T) {
|
||||
tests := map[string]struct {
|
||||
files map[string][]string
|
||||
count int
|
||||
}{
|
||||
"two containers": {
|
||||
files: map[string][]string{
|
||||
"container1": []string{
|
||||
"/boot/vmlinuz-5.14.0-427.18.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-5.14.0-427.24.1.el9_4.x86_64",
|
||||
"/boot/vmlinuz-4.14.0-427.18.1.el8_4.x86_64",
|
||||
},
|
||||
"container2": []string{
|
||||
"/boot/vmlinuz-0-rescue-eb46964329b146e39518c625feab3ea0",
|
||||
"/boot/vmlinuz-5.14.0-362.24.1.el9_3.aarch64",
|
||||
"/boot/vmlinuz-5.14.0-427.31.1.el9_4.aarch64+debug",
|
||||
"/boot/vmlinuz-5.14.0-284.30.1.el9_2.aarch64",
|
||||
"/boot/vmlinuz-5.14.0-427.31.1.el9_4.aarch64",
|
||||
},
|
||||
},
|
||||
count: 8,
|
||||
},
|
||||
"empty": {
|
||||
files: map[string][]string{},
|
||||
count: 0,
|
||||
},
|
||||
}
|
||||
for name, tt := range tests {
|
||||
t.Run(name, func(t *testing.T) {
|
||||
env := testenv.New(t)
|
||||
defer env.RemoveAll(t)
|
||||
for container, files := range tt.files {
|
||||
rootfs := filepath.Join(filepath.Join("/var/lib/warewulf/chroots", container), "rootfs")
|
||||
for _, file := range files {
|
||||
env.CreateFile(t, filepath.Join(rootfs, file))
|
||||
}
|
||||
}
|
||||
kernels := FindAllKernels()
|
||||
assert.Equal(t, tt.count, len(kernels))
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func Test_IsDebugOrRescue(t *testing.T) {
|
||||
tests := map[string]struct {
|
||||
path string
|
||||
debug bool
|
||||
rescue bool
|
||||
}{
|
||||
"default": {
|
||||
path: "/boot/vmlinuz-1.0.0",
|
||||
debug: false,
|
||||
rescue: false,
|
||||
},
|
||||
"debug": {
|
||||
path: "/boot/vmlinuz-5.14.0-427.31.1.el9_4.aarch64+debug",
|
||||
debug: true,
|
||||
rescue: false,
|
||||
},
|
||||
"rescue": {
|
||||
path: "/boot/vmlinuz-0-rescue-eb46964329b146e39518c625feab3ea0",
|
||||
debug: false,
|
||||
rescue: true,
|
||||
},
|
||||
}
|
||||
for name, tt := range tests {
|
||||
t.Run(name, func(t *testing.T) {
|
||||
kernel := &Kernel{ContainerName: "", Path: tt.path}
|
||||
assert.Equal(t, tt.debug, kernel.IsDebug())
|
||||
assert.Equal(t, tt.rescue, kernel.IsRescue())
|
||||
})
|
||||
os.RemoveAll(srvDir)
|
||||
os.RemoveAll(kernelDir)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user