use netParseIP and ParseMAC

check also MAC addresses and common formating

Signed-off-by: Christian Goll <cgoll@suse.de>

reformat ipaddr for test coverage

fixed processing of default values

updated transformer tests

correct behavior for tags

add tests for tags

new tests for primary network

Signed-off-by: Christian Goll <cgoll@suse.de>

internal/app/wwctl/node/add/main.go

@@ -9,7 +9,6 @@ import (
 	"github.com/spf13/cobra"
 )
 
-<<<<<<< HEAD
 /*
 RunE needs a function of type func(*cobraCommand,[]string) err, but
 in order to avoid global variables which mess up testing a function of
@@ -17,10 +16,12 @@ the required type is returned
 */
 func CobraRunE(vars *variables) func(cmd *cobra.Command, args []string) error {
 	return func(cmd *cobra.Command, args []string) error {
-	// run converters for different types
-	for _, c := range Converters {
-		c()
-	}
+		// run converters for different types
+		for _, c := range vars.converters {
+			if err := c(); err != nil {
+				return err
+			}
+		}
 		// remove the default network as all network values are assigned
 		// to this network
 		if _, ok := vars.nodeConf.NetDevs["default"]; ok && vars.netName != "" {

internal/app/wwctl/node/add/root.go

@@ -14,7 +14,7 @@ import (
 type variables struct {
 	netName  string
 	nodeConf node.NodeConf
-	converters []func()
+	converters []func() error
 }
 
 // Returns the newly created command

internal/app/wwctl/node/set/main.go

@@ -15,7 +15,9 @@ import (
 func CobraRunE(cmd *cobra.Command, args []string) (err error) {
 	// run converters for different types
 	for _, c := range Converters {
-		c()
+		if err := c(); err != nil {
+			return err
+		}
 	}
 	// remove the default network as the all network values are assigned
 	// to this network

internal/app/wwctl/node/set/root.go

@@ -38,7 +38,7 @@ var (
 	SetYes       bool
 	SetForce     bool
 	NodeConf     node.NodeConf
-	Converters   []func()
+	Converters   []func() error
 )
 
 func init() {

internal/app/wwctl/profile/add/main.go

@@ -16,7 +16,9 @@ import (
 func CobraRunE(cmd *cobra.Command, args []string) (err error) {
 	// run converters for different types
 	for _, c := range Converters {
-		c()
+		if err := c(); err != nil {
+			return err
+		}
 	}
 	// remove the default network as the all network values are assigned
 	// to this network

internal/app/wwctl/profile/add/root.go

@@ -25,7 +25,7 @@ var (
 	SetForce     bool
 	NetName      string
 	ProfileConf  node.NodeConf
-	Converters   []func()
+	Converters   []func() error
 )
 
 // GetRootCommand returns the root cobra.Command for the application.

internal/app/wwctl/profile/set/root.go

@@ -38,7 +38,7 @@ var (
 	SetForce     bool
 	NetName      string
 	ProfileConf  node.NodeConf
-	Converters   []func()
+	Converters   []func() error
 )
 
 func init() {