Don't read in binary data blobs to memory before sending to HTTP writer

This commit is contained in:
Gregory Kurtzer
2022-05-25 23:11:26 -07:00
parent 6ccc3ceecb
commit bf9ca54b8e

View File

@@ -2,7 +2,6 @@ package warewulfd
import (
"io"
"bytes"
"net/http"
"os"
"strconv"
@@ -36,18 +35,16 @@ func sendFile(w http.ResponseWriter, filename string, sendto string) error {
return errors.Wrap(err, "failed to seek")
}
var buf bytes.Buffer
_, err = io.Copy(&buf, fd)
w.Header().Set("Content-Disposition", "attachment; filename=kernel")
w.Header().Set("Content-Type", FileContentType)
w.Header().Set("Content-Length", FileSize)
_, err = io.Copy(w, fd)
if err != nil {
w.WriteHeader(http.StatusInternalServerError)
return errors.Wrap(err, "failed to copy")
}
w.Header().Set("Content-Disposition", "attachment; filename=kernel")
w.Header().Set("Content-Type", FileContentType)
w.Header().Set("Content-Length", FileSize)
_, err = buf.WriteTo(w)
wwlog.Send("%15s: %s", sendto, filename)
return err