Additional fixups, thanks @elguero!
This commit is contained in:
@@ -25,6 +25,10 @@ func CobraRunE(cmd *cobra.Command, args []string) error {
|
||||
fileName = args[2]
|
||||
}
|
||||
|
||||
if overlayName == "default" {
|
||||
return errors.New("refusing to delete the default overlay")
|
||||
}
|
||||
|
||||
if overlayKind != "system" && overlayKind != "runtime" {
|
||||
return errors.New("overlay kind must be of type 'system' or 'runtime'")
|
||||
}
|
||||
@@ -59,8 +63,35 @@ func CobraRunE(cmd *cobra.Command, args []string) error {
|
||||
}
|
||||
fmt.Printf("Deleted overlay: %s\n", args[0])
|
||||
|
||||
n, err := node.New()
|
||||
if err != nil {
|
||||
wwlog.Printf(wwlog.ERROR, "Could not open node configuration: %s\n", err)
|
||||
os.Exit(1)
|
||||
}
|
||||
|
||||
nodes, err := n.FindAllNodes()
|
||||
if err != nil {
|
||||
wwlog.Printf(wwlog.ERROR, "Could not get node list: %s\n", err)
|
||||
os.Exit(1)
|
||||
}
|
||||
|
||||
for _, node := range nodes {
|
||||
if overlayKind == "system" && node.SystemOverlay.Get() == overlayName {
|
||||
node.SystemOverlay.Set("default")
|
||||
} else if overlayKind == "runtime" && node.RuntimeOverlay.Get() == overlayName {
|
||||
node.RuntimeOverlay.Set("default")
|
||||
}
|
||||
}
|
||||
|
||||
err = n.Persist()
|
||||
if err != nil {
|
||||
return errors.Wrap(err, "failed to persist node updates")
|
||||
}
|
||||
|
||||
overlayName = "default"
|
||||
|
||||
} else {
|
||||
removePath := path.Join(overlayPath, overlayPath)
|
||||
removePath := path.Join(overlayPath, fileName)
|
||||
|
||||
if !util.IsDir(removePath) && !util.IsFile(removePath) {
|
||||
wwlog.Printf(wwlog.ERROR, "Path to remove doesn't exist in overlay: %s\n", removePath)
|
||||
|
||||
@@ -44,6 +44,11 @@ func CobraRunE(cmd *cobra.Command, args []string) error {
|
||||
os.Exit(1)
|
||||
}
|
||||
|
||||
if util.IsFile(path.Join(overlaySource, dest)) {
|
||||
wwlog.Printf(wwlog.ERROR, "A file with that name already exists in the %s overlay %s\n:", overlayKind, overlayName)
|
||||
os.Exit(1)
|
||||
}
|
||||
|
||||
err := util.CopyFile(source, path.Join(overlaySource, dest))
|
||||
if err != nil {
|
||||
return errors.Wrap(err, "could not copy file into overlay")
|
||||
|
||||
Reference in New Issue
Block a user