Commit Graph

1320 Commits

Author SHA1 Message Date
xu yang
1532547f49 address golang lint issue
Signed-off-by: xu yang <xyang@ciq.com>
2024-11-13 02:08:05 +00:00
Jonathon Anderson
55694e4694 Fix wwctl upgrade config description
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 09:23:41 -07:00
Christian Goll
a05c494638 fix tests after refactor
Signed-off-by: Christian Goll <cgoll@suse.com>
2024-11-11 10:56:30 +01:00
Christian Goll
a9eb4c3e26 Merge pull request #1524 from anderbubble/refactor-node-and-upgrade
Support cross-version upgrades
2024-11-11 10:45:47 +01:00
Xu Yang
0c2fc13a1d fix issue that --neettagdel does not work properly
Signed-off-by: Xu Yang <xyang@ciq.com>
2024-11-11 07:54:05 +00:00
Xu Yang
7f6cfafec9 hotfix failure test suite
Signed-off-by: Xu Yang <xyang@ciq.com>
2024-11-11 07:36:49 +00:00
Jonathon Anderson
ab6c6d2a05 Mark two upgrade arguments as required
Based on TSC feedback.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:50 -07:00
Jonathon Anderson
e80c639b11 Convert config to *bool
Supports leaving booleans unspecified in YAML.

Boolean methods allow the templates to continue using previous names for
boolean values.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:48 -07:00
Jonathon Anderson
b37d49d6de Support upgrading warewulf.conf
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:45 -07:00
Jonathon Anderson
6a1abd52a5 Support printing upgraded nodes.conf
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:43 -07:00
Jonathon Anderson
393629321c Optionally replace wwinit and generic overlays during upgrade
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:41 -07:00
Jonathon Anderson
263e3959c2 Fix handling of upgrading booleans
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:40 -07:00
Jonathon Anderson
981d11a012 Initial wwctl upgrade command
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:38 -07:00
Jonathon Anderson
336577c221 Fix linter errors
Capture and generate warnings for boolean conversion errors.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:36 -07:00
Jonathon Anderson
835506f5e8 Support inserting defaults during config upgrade
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:33 -07:00
Jonathon Anderson
ff40c0fed2 Node upgrade tests
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:04 -07:00
Jonathon Anderson
fdbdf88df0 Rename NodeConf to NodesConf
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:02 -07:00
Jonathon Anderson
76acd8ff80 Rename RootConf to WarewulfYaml
Matches the new name of NodesYaml

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:09:01 -07:00
Jonathon Anderson
a2c778b7ee Remove ExportedYml
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:08:59 -07:00
Jonathon Anderson
1acbfc1ffa First commit of backwards-compatible config datastructures
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:08:57 -07:00
Jonathon Anderson
8a602e8a76 Return OnBoot to wwtype.WWbool
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:08:55 -07:00
Jonathon Anderson
a7325b6ffa Remove WW_INTERNAL
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:08:54 -07:00
Jonathon Anderson
ab293d88ea Fix extraneous whitespace in flag definition
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:08:52 -07:00
Jonathon Anderson
0665d5dc88 Refactor node
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-11 00:08:47 -07:00
Christian Goll
e6f5c63c21 Merge pull request #1539 from anderbubble/restore-skipped-tests
Restore skipped tests
2024-11-09 19:49:46 +01:00
Jonathon Anderson
9c3b52b27f Restore skipped tests
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-08 07:12:35 -07:00
Jonathon Anderson
8efec499a2 Revert changes to testenv and fix bmc tests
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-07 23:01:32 -07:00
Jonathon Anderson
8189390e03 Switch bmc templates from html/template to text/template
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-07 23:01:32 -07:00
Jonathon Anderson
c25eaa8855 Move default ipmi template to default profile
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-07 23:01:32 -07:00
Jonathon Anderson
9ddb491ba3 Rename BmcTemplate to Template
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-07 23:01:32 -07:00
Jonathon Anderson
141bcd8d40 Refactor ipmi tests as table-driven tests
Also prefix each sensor line.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-07 23:01:32 -07:00
Jonathon Anderson
2e2a7d7de3 rebased for the use without NodeInfo
make fanout configureable via commanline

Signed-off-by: Christian Goll <cgoll@suse.com>
2024-11-07 23:01:32 -07:00
Christian Goll
0490f4c9a5 added documentation for ipmi templates
Signed-off-by: Christian Goll <cgoll@suse.com>
2024-11-07 23:01:32 -07:00
Christian Goll
f53ae48ae6 added test for power status
Signed-off-by: Christian Goll <cgoll@suse.com>
2024-11-07 23:01:32 -07:00
Christian Goll
4597fdfaa9 use ipmitool created from template file
Signed-off-by: Christian Goll <cgoll@suse.com>
2024-11-07 23:01:32 -07:00
Christian Goll
10ea0ac78d use ipmi interface from node.NodeConf
Signed-off-by: Christian Goll <cgoll@suse.com>
2024-11-07 23:01:32 -07:00
Christian Goll
0dd0317740 replaced errors.Wrap with fmt.Errorf
Signed-off-by: Christian Goll <cgoll@suse.com>
2024-11-07 22:57:29 -07:00
Jonathon Anderson
a8554b0af5 Replace olekukonko/tablewriter with cheynewallace/tabby
- Closes #1497
- Closes #1498

This library is simpler and doesn't produce extraneous whitespace around
the output.

A local helper function restores "--" for empty output.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-07 22:44:50 -07:00
Jonathon Anderson
3cbb295e7b Remove escape character from IPMI attribute list
This wasn't in the header, and usually wasn't displaying anything
anyway.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-07 22:44:50 -07:00
Jonathon Anderson
4e9b097eb6 Only output node and profile list headers once
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-07 22:44:50 -07:00
Jonathon Anderson
a3ede90093 Use "default" netname during add, set
- Closes #1499

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-07 22:40:58 -07:00
Jonathon Anderson
ad7582692c Omit the wwclient section from warewulf.conf if empty
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-06 19:07:06 -07:00
Jonathon Anderson
cec95b14f0 Update default warewulfd port to match initial configuration
We've been shipping a warewulf.conf that defines the warewulfd port as
9873, and a firewalld service that uses this port as well; but the
default value in the YAML data-structure has been 9983.

This changes the default port to 9873 to match the configuration we've
been shipping, and removes the port from the initial configuration file
(to use the default value).

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-06 19:07:05 -07:00
Jonathon Anderson
a0c58e4183 Simplify passing of arguments through wwctl container exec
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-06 15:43:14 -07:00
Christian Goll
f4308ca02d Merge pull request #1514 from anderbubble/remove-iszero
Remove unused IsZero function
2024-11-06 17:36:39 +01:00
Christian Goll
6e55a00076 Merge pull request #1478 from anderbubble/warewulfd-deadcode
Remove deadcode from warewulfd
2024-11-06 11:19:07 +01:00
Jonathon Anderson
093c74add4 Remove unused IsZero function
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-11-01 18:39:40 -06:00
Jonathon Anderson
fcc15eb8ef Fix boolean pointer handling
- Refactor field reflection for clarity
- Update tests for clarity

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-10-31 15:52:01 -06:00
Jonathon Anderson
82bf0ee6d4 Remove deadcode from warewulfd
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-10-31 14:58:24 -06:00
Jonathon Anderson
d33ca6ff53 Simplify warewulfd logging
- Collapse SEND and RECV logs into INFO.
- Add /etc/default/warewulfd

Closes #725

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2024-10-31 14:52:48 -06:00