Commit Graph

108 Commits

Author SHA1 Message Date
Christian Goll
96644be621 allow UNSET for IP addresses
added more tests for GetFrom
allow UNSET and handle empty hwaddr

Signed-off-by: Christian Goll <cgoll@suse.de>
2023-03-23 11:17:38 +01:00
Christian Goll
b0602133ec use netParseIP and ParseMAC
check also MAC addresses and common formating

Signed-off-by: Christian Goll <cgoll@suse.de>

reformat ipaddr for test coverage

fixed processing of default values

updated transformer tests

correct behavior for tags

add tests for tags

new tests for primary network

Signed-off-by: Christian Goll <cgoll@suse.de>
2023-03-23 11:17:07 +01:00
Christian Goll
c14dd3c6d1 check the yaml direclty after unmarshalling 2023-03-23 11:15:50 +01:00
Christian Goll
13bc378a6b Refactor the CreateFlags command
* added the additional type flag, which can be bool,IP
* UNDEF is recognized for the bool flag
* 0.0.0.0 must be used as UNDEF for IP flag

Signed-off-by: Christian Goll <cgoll@suse.de>
2023-03-23 11:15:50 +01:00
Christian Goll
eae6d195b0 Merge pull request #676 from hpcng/RefactorProfileList
Refactor profile list
2023-02-24 15:14:22 +01:00
Jonathon Anderson
e8e9c4f3bd Merge branch 'development' into lint-update 2023-02-02 14:38:33 -07:00
Christian Goll
edce6b8140 refactored profile list command 2023-02-02 12:22:07 +01:00
Jonathon Anderson
5b50ef724c Fix 'nodes' alias for 'node' not 'profile'
Fixes #609

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-01-06 14:17:46 -07:00
Christian Goll
9539e20a4e add -y flag to wwctl profile add
close #610

Signed-off-by: Christian Goll <cgoll@suse.de>
2022-12-22 14:54:42 +01:00
Jonathon Anderson
248c5896ce Correct confirmation output in profile set
Closes #600

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2022-12-17 18:00:23 -07:00
mslacken
ab0ee87629 updated linter and fixed deprecated stuff 2022-10-14 17:40:16 +02:00
Christian Goll
4fe584547b Merge branch 'development' into wwlog-newlines 2022-10-13 14:46:03 +02:00
Christian Goll
33504354c2 Merge branch 'development' into node-edit 2022-10-13 09:59:38 +02:00
Christian Goll
d0bfac6e24 add nodes as alias for node 2022-09-22 07:56:53 +02:00
Christian Goll
8e0fd64c7e add profile edit (copy&paste) from node edit 2022-09-19 16:01:36 +02:00
Jonathon Anderson
0b3e862bea Remove trailing newline from wwlog
I noticed that some wwlog calls included a trailing newline, but others
did not. I tested both in isolation and discovered that the behavior was
consistent regardless of whether a trailing newline was included. I
further confirmed in code that wwlog appends a trailing newline
automatically if it is not present; so a trailing newline is unnecessary
in individual calls.

This commit removes trailing newlines from all calls to make them
consistent. It also replaces two calls to wwlog.Printf. (see #534)

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2022-09-15 12:38:03 -06:00
Jonathon Anderson
22910958b5 Replace all instances of wwlog.Printf
wwlog provides named loggers for each level, which requires
less code and is clearer than wwlog.Printf. The code has
included a mix of both, but this commit consolidates existing
code on the per-level functions.

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2022-09-11 08:00:23 -06:00
Christian Goll
18eb531d4b fixed deletion of network and deletion of tags 2022-09-02 16:45:37 +02:00
Christian Goll
255ff61dc8 adding netname option back 2022-08-31 17:05:28 +02:00
Christian Goll
b485ea999f removed optionStrMap in favor of NodeConf
openStrMap is a map[string]string which is sent arround. This is now
done by using a unmarshalled NodeConf instead.
2022-08-18 19:22:55 +02:00
Christian Goll
41d12888ab reflections for unmarshal 2022-08-10 14:16:48 +02:00
Christian Goll
d252b974bf Fix Nodeadd with ipaddr count 2022-07-21 08:41:36 +02:00
Christian Goll
1dd519a7e6 clean up and linting fix 2022-07-18 15:04:38 +02:00
Christian Goll
e6ef30ed53 porfile add has now all otions of set 2022-07-15 11:10:12 +02:00
Christian Goll
510f6a60a9 added excludellist to CreateFlags 2022-07-14 10:40:46 +02:00
Christian Goll
e0c62a81a4 testing profile set 2022-07-14 10:35:27 +02:00
Christian Goll
14b86a5e8e added profile set over API 2022-07-13 15:56:04 +02:00
jcsiadal
9b6b93a5cb Rename default to primary in src
Signed-off-by: jcsiadal <jeremy.c.siadal@intel.com>
2022-05-05 03:13:21 +00:00
Gregory M. Kurtzer
04decd799f Merge pull request #410 from gmkurtzer/boolean_print_fixes
Align boolean prints
2022-05-03 22:12:39 -07:00
Gregory Kurtzer
c95c518dde Align boolean prints 2022-04-27 22:33:34 -07:00
jcsiadal
dbd747788f wwctl profile fixes
Signed-off-by: jcsiadal <jeremy.c.siadal@intel.com>
2022-04-19 21:59:34 +00:00
Christian Goll
edc7c04bc2 PrintB returns string 2022-04-14 11:43:02 +02:00
Christian Goll
f9848455c7 output ipmi write status 2022-04-14 11:29:24 +02:00
Christian Goll
95050a44ce add user defined keys for networks/netdev
Every network in the profile and for the nodes can have induvidual keys values
pairs, called Tags, which are propergated to the templates. So they can be used
for things like MTU size like
  `wwct node set node01 --nettag mtu=9000`
and in in ifcfg.xml.ww
```
{{ if $netdev.Tags.mtu -}}
<mtu> {{ $netdev.Tags.mtu }} </mtu>
{{ end -}}
```
2022-04-06 21:36:17 +02:00
jcsiadal
bfde70cf8a Error free lint
Signed-off-by: jcsiadal <jeremy.c.siadal@intel.com>
2022-04-04 17:01:11 +00:00
Christian Goll
c0f7ecf357 store the ovelats as yaml list 2022-03-24 19:45:51 +01:00
Christian Goll
88631a98d3 fixed linting 2022-03-02 21:24:15 +01:00
Christian Goll
5ac75661c9 Only write to IPMI if this is explictly wanted 2022-03-02 21:24:05 +01:00
Gregory M. Kurtzer
88832420ca Merge pull request #306 from gmkurtzer/container_kernel_integration
Utilize containerized kernel by default
2022-02-27 18:03:25 -08:00
Gregory Kurtzer
1203186194 Support kernel overrides from the host or other containers 2022-02-17 07:37:04 +00:00
Gregory Kurtzer
104bc7527d Restored deleted kernel components for overrides 2022-02-17 06:21:40 +00:00
MatthewHink
a01e8319d2 Allow asset tags in the profile.
Warn and ignore ip addresses and hardware addresses.
2022-02-16 11:41:44 -05:00
MatthewHink
a29e9ed6be Remove unique settings from profile set. Warn if set in the node DB.
IP address
MAC address
Asset Tag
2022-02-15 10:58:28 -05:00
Gregory Kurtzer
5a0c13225e Utilize containerized kernel and remove kernel Support 2022-02-15 06:49:24 +00:00
Gregory M. Kurtzer
d38d023782 Merge pull request #297 from gmkurtzer/discoverable-fix
Discoverable and network fixes
2022-02-11 19:23:46 -08:00
Gregory Kurtzer
e6a3810d20 Fixing oddball network configuration parameters 2022-02-12 03:08:33 +00:00
Gregory Kurtzer
30994fd60d Setting sane defaults for node and profile selection 2022-02-12 01:27:58 +00:00
Gregory Kurtzer
ffaf794a42 Changed "key" paramaters to tags and cleaned up interface 2022-02-11 05:52:46 +00:00
Gregory Kurtzer
7381efb0fc Fix the help output for set -N ... 2022-02-11 04:55:04 +00:00
Gregory Kurtzer
c5cbd3d6e3 Simplified default network device configuration 2022-02-10 16:35:46 +00:00