Commit Graph

58 Commits

Author SHA1 Message Date
Christian Goll
3eaeac46d2 use canonical os.TempDir 2023-02-03 15:39:00 +01:00
Christian Goll
80687f9475 removed mounts.conf and check of env shell 2023-02-03 15:15:41 +01:00
Christian Goll
05237935eb node option also for shell and respect env $SHELL 2023-01-31 18:05:18 +01:00
Christian Goll
317cd5d4e0 add option for node rendering 2023-01-31 17:45:09 +01:00
Christian Goll
157c3cd923 getting defaults mounts from warewulf.conf 2023-01-31 16:04:08 +01:00
Christian Goll
d82314460f added support for mounts.conf for container exec 2023-01-31 16:04:07 +01:00
Christian Goll
71a3867bbe create temporary dir for overlayfs not in __child 2023-01-31 16:04:07 +01:00
Christian Goll
6d560ac02a create overlayfs for ephermal mount points 2023-01-31 16:04:07 +01:00
Christian Goll
a4202df508 create overlay of missing mount points 2023-01-31 16:04:07 +01:00
Christian Goll
d30d523866 respect read only rootfs for containers 2023-01-31 16:04:07 +01:00
Christian Goll
7ade65c73f cleaned up container exec __child 2023-01-31 16:04:07 +01:00
Christian Goll
5249931ab0 do not call container exec for shell call 2023-01-31 16:04:07 +01:00
Christian Goll
55f61a7c18 pass log level to container exec 2023-01-31 16:03:57 +01:00
Jonathon Anderson
0b3e862bea Remove trailing newline from wwlog
I noticed that some wwlog calls included a trailing newline, but others
did not. I tested both in isolation and discovered that the behavior was
consistent regardless of whether a trailing newline was included. I
further confirmed in code that wwlog appends a trailing newline
automatically if it is not present; so a trailing newline is unnecessary
in individual calls.

This commit removes trailing newlines from all calls to make them
consistent. It also replaces two calls to wwlog.Printf. (see #534)

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2022-09-15 12:38:03 -06:00
Jonathon Anderson
22910958b5 Replace all instances of wwlog.Printf
wwlog provides named loggers for each level, which requires
less code and is clearer than wwlog.Printf. The code has
included a mix of both, but this commit consolidates existing
code on the per-level functions.

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2022-09-11 08:00:23 -06:00
Gregory Kurtzer
8717b91938 Avoid container build if exit non-zero 2022-05-25 14:46:16 -07:00
Gregory Kurtzer
60b586b69a Don't do SyncUids by default always 2022-05-03 21:52:13 -07:00
Christian Goll
7e42286610 fixed linting 2022-04-07 11:35:34 +02:00
Christian Goll
2567246067 fixed linting 2022-04-06 21:44:00 +02:00
Christian Goll
db2dcbfbe2 will always run syncuids on exec and import 2022-04-06 21:44:00 +02:00
Christian Goll
5fb10130f3 check for modifcation of passwd/group after exec 2022-04-06 21:44:00 +02:00
Gregory Kurtzer
b60cacbd0f Revert "removed unused container child"
This reverts commit 30bc445a89.
2022-03-02 19:53:10 -08:00
Christian Goll
30bc445a89 removed unused container child 2022-03-02 15:39:47 +01:00
Gregory Kurtzer
2260be9f8f Working implemnetation of #271 2022-02-13 04:22:12 +00:00
Gregory M. Kurtzer
486e0079c6 Merge pull request #271 from mslacken/run-exec-exit
execute './.ww4/runExit` on exit of container exec
2022-02-12 19:31:40 -08:00
Christian Goll
10fdacee77 added wwctl container shell 2022-02-09 10:54:57 +01:00
Christian Goll
100cfe6a13 finaly added /usr/bin/bash as default to cnt exec 2022-02-04 11:06:27 +01:00
Christian Goll
df127b179d q 2022-02-03 09:59:24 +01:00
Christian Goll
ad87ba7647 execute './.ww4/runExit` on exeit of container exec 2022-01-31 17:20:24 +01:00
Christian Goll
9d80a71cd8 will exec /usr/bin/bash if no cmd is provided 2022-01-31 17:06:56 +01:00
jcsiadal
0b93d6c277 Update help
Signed-off-by: jcsiadal <jeremy.c.siadal@intel.com>
2021-11-08 11:36:21 -08:00
Christian Goll
8010cd2435 dynamic nouns for 'wwwctl container' 2021-09-24 14:36:23 +02:00
Michael L. Young
0020d529b9 Fix panic when failing to include the command to be run by the
'container exec' command.

Update documentation for the 'container exec' command.
2021-09-20 16:57:01 -04:00
Gregory M. Kurtzer
4b5e3fd6eb Merge pull request #117 from WestleyK/remove_commented_code
Remove commented test code
2021-09-08 16:12:09 -07:00
WestleyR
cab2d4a316 Remove commented test code
Seems to be extra test code from
09a83ff904.
2021-09-08 14:12:20 -07:00
Gregory Kurtzer
84c0c72219 MS_REC added to MS_PRIVATE mount on root 2021-09-08 11:52:22 -07:00
Gregory Kurtzer
09a83ff904 Container exec fixups 2021-09-08 11:40:14 -07:00
WestleyR
4edc16953e Fix linting issues 2021-09-07 20:48:51 -07:00
Gregory Kurtzer
4c8edc16fe Changed API name to valid path 2021-09-02 15:34:19 -07:00
Gregory Kurtzer
ed64386b8b remove debug print 2021-09-01 21:20:50 -07:00
Gregory Kurtzer
caf9f4b80f Have more intelligence on splitting bind paths 2021-09-01 21:13:46 -07:00
Gregory Kurtzer
198791fb10 add default and sane path to container exec 2021-09-01 19:26:38 -07:00
Gregory Kurtzer
fc7182d7bd Don't bind resolv.conf, copy on import 2021-09-01 19:23:13 -07:00
Gregory Kurtzer
371767daed Merge branch 'main' of github.com:hpcng/warewulf into cleanups 2021-08-22 19:10:09 -07:00
Gregory Kurtzer
a82e1b0ea5 Fixed formatting across entire project 2021-08-21 08:04:47 -07:00
Gregory Kurtzer
cf45e5b8f6 Removing another debug Println() 2021-08-20 18:21:26 -07:00
Gregory Kurtzer
b3027e44ba Missed a debug Println() 2021-08-20 18:19:37 -07:00
Gregory Kurtzer
7826f69656 Support binds in container exec command
This addresses issue #88.
2021-08-20 14:16:16 -07:00
Gregory Kurtzer
6357e31438 Support container import of chroot directory 2021-02-24 21:01:56 -08:00
Ian Kaneshiro
846b45524c Tidy up
- Ran goimports to format code and imports
- Removed unused module from go.mod
- Added .editorconfig to keep formatting standard across contributors
2021-02-16 11:54:12 -08:00