kelvin/warewulf
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
2,744 Commits 1 Branch 0 Tags
a3ede90093deec272304b7f3d1e43e7c7ef1e308
Commit Graph

1280 Commits

Author SHA1 Message Date
Jonathon Anderson
a3ede90093 Use "default" netname during add, set 
- Closes #1499

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-11-07 22:40:58 -07:00
Jonathon Anderson
ad7582692c Omit the wwclient section from warewulf.conf if empty 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-11-06 19:07:06 -07:00
Jonathon Anderson
cec95b14f0 Update default warewulfd port to match initial configuration 
We've been shipping a warewulf.conf that defines the warewulfd port as
9873, and a firewalld service that uses this port as well; but the
default value in the YAML data-structure has been 9983.

This changes the default port to 9873 to match the configuration we've
been shipping, and removes the port from the initial configuration file
(to use the default value).

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-11-06 19:07:05 -07:00
Jonathon Anderson
a0c58e4183 Simplify passing of arguments through wwctl container exec 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-11-06 15:43:14 -07:00
Christian Goll
f4308ca02d Merge pull request #1514 from anderbubble/remove-iszero 
Remove unused IsZero function
 2024-11-06 17:36:39 +01:00
Christian Goll
6e55a00076 Merge pull request #1478 from anderbubble/warewulfd-deadcode 
Remove deadcode from warewulfd
 2024-11-06 11:19:07 +01:00
Jonathon Anderson
093c74add4 Remove unused IsZero function 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-11-01 18:39:40 -06:00
Jonathon Anderson
fcc15eb8ef Fix boolean pointer handling 
- Refactor field reflection for clarity
- Update tests for clarity

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-31 15:52:01 -06:00
Jonathon Anderson
82bf0ee6d4 Remove deadcode from warewulfd 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-31 14:58:24 -06:00
Jonathon Anderson
d33ca6ff53 Simplify warewulfd logging 
- Collapse SEND and RECV logs into INFO.
- Add /etc/default/warewulfd

Closes #725

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-31 14:52:48 -06:00
Jonathon Anderson
983214f253 Simplify wwctl server 
- Always run in the foreground
- Always log to stdout/err (unless syslog is requested)
- Update systemd to reload with a direct signal
- Omit any pidfile for "warewulfd"

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-31 14:52:47 -06:00
xu yang
82aaf9b9ec tidy and update related dependencies 
Signed-off-by: xu yang <xyang@ciq.com>
 2024-10-31 10:34:59 -06:00
xu yang
97c6772e51 Return non-zero exit code on overlay sub-commands 
Signed-off-by: xu yang <xyang@ciq.com>
 2024-10-30 20:51:44 -06:00
Christian Goll
dbdd85fe2b add platform parameter for container import 
Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-29 10:35:33 -06:00
xu yang
139b9880a0 Return non-zero exit code on profile sub-commands 
Signed-off-by: xu yang <xyang@ciq.com>
 2024-10-28 16:04:25 -06:00
xu yang
9daaab2983 wwctl should return non-zero exit code on wwctl kernel sub-commands 
Signed-off-by: xu yang <xyang@ciq.com>
 2024-10-28 15:54:41 -06:00
Jonathon Anderson
fbd5ca9895 Recommended refactors 
- make sure spec sets new cache dir
- move clean out of api
- capture warewulfconf.Paths.Cachedir+"/warewulf" in once place
- split Clean() into multiple functions
- remove WriteFileAbs

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-28 15:20:41 -06:00
Christian Goll
ff84974506 added wwctl clean to remove cache/dead overlays 
Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-28 15:20:41 -06:00
Christian Goll
511938ac5c add Cachedir and point OCIBlobCache to it 
Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-28 15:20:41 -06:00
Jonathon Anderson
ccb096104a Remove an erroneous colon suffix from a log message 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-25 14:58:03 -06:00
Christian Goll
cb9e6e8be0 Removed rest of direct yaml.v2 deps 
Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-25 14:33:57 -06:00
Jonathon Anderson
62a58c500e Move API docs into api path 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-18 15:09:09 -06:00
Jonathon Anderson
b331fd12af Remove dead code 
Verified with

```
deadcode -test ./...
```

Followed-up with a lint check.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-18 15:09:01 -06:00
Jonathon Anderson
4b4234994c Misc whitespace handling fixes 
Also fixes handling of mtu value in Debian networking.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-18 00:31:19 -04:00
Jonathon Anderson
d3cd31fdc0 Restore a commented-out test 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-18 00:06:22 -04:00
Jonathon Anderson
30ac144044 Restored profile list tests and resolved exposed bugs 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-17 23:58:37 -04:00
Jonathon Anderson
0be1e8464a End-line whitespace cleanup 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-17 23:11:33 -04:00
Jonathon Anderson
bb5d1d17ed Revert NetDevs.Manual back to NetDevs.OnBoot 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-17 23:00:57 -04:00
Jonathon Anderson
df37018f79 Fix wwctl node edit 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-17 23:00:52 -04:00
Jonathon Anderson
d91d273ac7 Use ProfileConf rather than NodeConf for profile commands 
This removes node-only attributes, like a profile list, from profile commands.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-17 15:39:59 -04:00
Jonathon Anderson
6460ca827a Remove debug output from a test 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-17 15:39:59 -04:00
Jonathon Anderson
5fbeaa1873 Remove an extraneous tab 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-17 15:39:59 -04:00
Jonathon Anderson
322a47033a Remove commented-out code 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-17 15:39:59 -04:00
Jonathon Anderson
f7f8dfcf5c Fix a regression in passing metadata to grub.cfg.ww 
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
 2024-10-17 15:39:59 -04:00
Christian Goll
0c6e7cc58a fixes for split overlays 
Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 15:39:54 -04:00
Christian Goll
c08cd82e68 don't use net.IPMask 
net.IPMask doesn't have any advantages, as it would
marshalled to
mask:
  - 1
  - 2
  - 3
  - 4

Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 15:30:54 -04:00
Christian Goll
9fdb9ca792 updated overlays 
Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 15:30:54 -04:00
Christian Goll
342236b9b9 updated test for yaml/v3 
Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 15:30:54 -04:00
Christian Goll
9ba1aa8d63 api changes to modify unexported fields 
changes can now not be done directly but must
go to SetNode or SetProfile. Although its also
now possible to access the field direclty with
GetNodePtr

Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 15:30:54 -04:00
Christian Goll
4c8a07f1dc changes for yaml/v3 for wwctl commands 
Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 15:30:54 -04:00
Christian Goll
bddcdfcac4 added new types for primitves 
this types like WWbool are needed so that they can
have their own command line parses which allows a UNDEF
for e.g. bool or ints.

Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 15:30:54 -04:00
Christian Goll
5bd4fd4712 use yaml/v3 and don't export Nodes 
introduced wwbool and don't export
Nodes and NodeConfs. This requires new
explict Yaml (un)marshaling as the standard
marshaller won't touch these fields

Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 15:30:54 -04:00
Christian Goll
ac6cd69ca6 fix test to run without NodeInfo 
Also removed --fullall from node list and profile list

Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 15:30:47 -04:00
Christian Goll
ffef31969e api changes for use without NodeInfo 
Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 13:35:42 -04:00
Christian Goll
457c7c16b1 wwctl commands without NodeInfo 
mostly remove Get and calls for the id

Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 13:35:42 -04:00
Christian Goll
28a7b9fe84 removed NodeInfo and using NodeConf instead 
This is a significant change in the undelying data model!

nodeDb, err := node.New()

will result in a structure which contains the on disk
values. Only

nodeDb.FindAllNodes() or nodeDb.GetNode(id) will give
the nodes with its merged in profiles.

Signed-off-by: Christian Goll <cgoll@suse.com>
 2024-10-17 13:35:42 -04:00
xu yang
f7c4b32fc2 Fix issue that domain globs not supported during wwctl node delete. 
Signed-off-by: xu yang <xyang@ciq.com>
 2024-10-11 09:50:48 +00:00
xu yang
f51808bc75 fix issue that pattern matching broken on node set 
Signed-off-by: xu yang <xyang@ciq.com>
 2024-10-11 02:27:33 +00:00
xu yang
f973733130 wwctl node set requires mandatory pattern input 
Signed-off-by: xu yang <xyang@ciq.com>
 2024-09-30 12:50:20 +00:00
Christian Goll
62f3cfb868 Merge pull request #1440 from JasonYangShadow/issue/1439 
wwctl should return non-zero exit code on wwctl power sub-commands
 2024-09-30 08:50:05 +02:00