The `mv` command is typically used to rename files in a Linux
environment, so keep that convention here for container rename.
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
The original implementation presented a warning if more than two
arguments were presented, and didn't handle the case where fewer than
two arguments were provided. This change requires precisely two
arguments and returns an error otherwise.
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
Since grub support no longer depends on a default container, no longer
automatically set default container on import.
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
Also the boot method is now configured globaly as this is
the only way to make sure that unkonwn nodes get the right
stuff
Signed-off-by: Christian Goll <cgoll@suse.com>
Previously ephemeral container mounts were performed in /tmp. Now these
mounts are overlayed on the same fs as is used for chroots.
Signed-off-by: Christian Goll <cgoll@suse.com>
Also refactor New and Get to return pointers to match BaseConf methods.
This makes calling the methods immediately on the return values of the
constructors easier.
Also move config.ConfigFile to buildconfig.go.in. ConfigFile is still
used by wwctl as a default config file to reference; but it is removed
from other locations now.
Removed Persist, as nothing called it.
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
Since BaseConf.New could return a cached BaseConf, rather than always
constructing a new struct, I've renamed it to Get to more accurately
reflect its use. A new New() method is called by Get and always
initializes a new struct.
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
The caching functionality of nodes.conf, and the optional persistence
functionality that came with it, appears to have been preventing
actually writing the configuration to disk in all cases. This change
fixes the ability to write to nodes.conf.
Somewhat opinionatedly, this change removes the caching functionality of
nodes.conf. The tests have also been updated to use real files for i/o
rather than tying into the caching system, making them more accurately
test the ability of Warewulf to actually read and write its
configuration.
Fixes#779
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
Warewulf sample node images are now built automatically with GitHub CI/CD,
targeting ghcr.io. This updates the documentation to reference that location
rather than DockerHub.
Addresses #732
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
Commit d8cd6049 introduced erroneous output coming from an
inner function of container show, and (seemingly) erroneously
replaces valid kernel versions with "not found". This commit
fixes both of those issues, and moves the output to the outer
cli function.
