When editing an overlay, the temporary file was created within the overlay directory structure. This could lead to the temporary file being included in the overlay if not cleaned up properly. This change modifies the behavior to create the temporary file in the system's default temporary directory, avoiding any potential issues with the overlay itself. Not using this change the temporary file can be seen in the overlay: DEBUG : Using temporary file /usr/share/warewulf/overlays/host/ww-overlay-edit-2879742493 DEBUG : Checking if path exists as a file: /usr/share/warewulf/overlays/host/rootfs/etc/hosts.ww DEBUG : ExecInteractive(tee, [/usr/share/warewulf/overlays/host/ww-overlay-edit-2879742493]) # find /srv | grep ww-overlay /srv/warewulf/overlays/host/ww-overlay-edit-2879742493 With this patch applied: DEBUG : Using temporary file /tmp/ww-overlay-edit-266752840 DEBUG : Checking if path exists as a file: /usr/share/warewulf/overlays/host/rootfs/etc/hosts.ww DEBUG : ExecInteractive(tee, [/tmp/ww-overlay-edit-266752840]) # find /srv | grep ww-overlay Assisted-by: Gemini 2.5 Pro Signed-off-by: Adrian Reber <areber@redhat.com>
2.3 KiB
2.3 KiB
Contributors
- Gregory Kurtzer gmkurtzer@gmail.com @gmk
- Christian Goll cgoll@suse.de @mslacken
- Jeremy Siadal jeremy.c.siadal@intel.com @jcsiadal
- Niko Kivel niko.kivel@psi.ch @kivel
- Shannon V. Davidson svdavidson@charter.net
- Brian Clemens brian@ciq.com @brianclemens
- Michael L. Young myoung@ciq.com @ajyounge
- Ian Kaneshiro iankane@umich.edu @ikaneshiro
- Carter Dodd cdodd@nanohmics.com @kcdodd
- MatthewHink matthew_hink@yahoo.com @MatthewHink
- WestleyR westleyr@nym.hush.com @WestleyK
- Michael L. Young elgueromexicano@gmail.com
- Yong Qin yongq@nvidia.com
- Yoshiaki Senda yoshiaki@live.it
- Cooper, Trevor tcooper@sdsc.edu
- Masahiko Ohkubo masahiko.ohkubo+github@gmail.com
- John Hanks griznog@gmail.com @griznog
- Rob Jansen jansen@cs.umn.edu
- svdavidson svdavidson@charter.net
- David McFarlane @Prepultrue
- Jean-Baptiste Denis jbd@jbdenis.net
- TerranWorks tdunn3@uco.edu
- Jonathon Anderson janderson@ciq.com @anderbubble
- Brian Phan bphan@ciq.com
- Jeffrey Frey @jtfrey
- Xu Yang(Jason Yang) jasonyangshadow@gmail.com @JasonYangShadow
- Matt Jolly Kangie@footclan.ninja @Kangie
- Arnaud LECOMTE contact@arnaud-lcm.com
- Ryan Novosielski novosirj@rutgers.edu
- Andreas Skau andreas@scheen.no @buzh
- Dietmar Rieder dietmar.rieder@i-med.ac.at
- Andreas Henkel henkel@uni-mainz.de
- Timothy Middelkoop tmiddelkoop@internet2.edu
- Shane Nehring snehring@iastate.edu
- Tobias Ribizel mail@ribizel.de
- Tobias Poschwatta poschwatta@zib.de
- Josh Burks jeburks2@asu.edu
- Elmar Pruesse pruessee@njhealth.org @epruesse
- Adam Michel elfurbe@furbism.com @elfurbe
- Brandon Biggs brandonsbiggs@gmail.com
- Howard Van Der Wal howard.a.vanderwal@protonmail.com @metalllinux
- Nicholas Porter nap23@unm.edu
- Ian Kaufman ikaufman@ucsd.edu @iankgt40
- Daniele Colombo @dacolombo
- Stephen Simpson @ssimpson89
- Rafael Lopez raflopez1@gmail.com @rafalop
- Arian Cabrera @acabrera86
- Dacian Reece-Stremtan dacianstremtan@gmail.com @dacianstremtan
- Adrian Reber areber@redhat.com