I noticed that some wwlog calls included a trailing newline, but others did not. I tested both in isolation and discovered that the behavior was consistent regardless of whether a trailing newline was included. I further confirmed in code that wwlog appends a trailing newline automatically if it is not present; so a trailing newline is unnecessary in individual calls. This commit removes trailing newlines from all calls to make them consistent. It also replaces two calls to wwlog.Printf. (see #534) Signed-off-by: Jonathon Anderson <janderson@ciq.co>
42 lines
810 B
Go
42 lines
810 B
Go
package delete
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/hpcng/warewulf/internal/pkg/kernel"
|
|
"github.com/hpcng/warewulf/internal/pkg/node"
|
|
"github.com/hpcng/warewulf/internal/pkg/wwlog"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
func CobraRunE(cmd *cobra.Command, args []string) error {
|
|
|
|
nodeDB, err := node.New()
|
|
if err != nil {
|
|
wwlog.Error("Could not open nodeDB: %s", err)
|
|
os.Exit(1)
|
|
}
|
|
|
|
nodes, _ := nodeDB.FindAllNodes()
|
|
|
|
ARG_LOOP:
|
|
for _, arg := range args {
|
|
for _, n := range nodes {
|
|
if n.Kernel.Override.Get() == arg {
|
|
wwlog.Error("Kernel is configured for nodes, skipping: %s", arg)
|
|
continue ARG_LOOP
|
|
}
|
|
}
|
|
|
|
err := kernel.DeleteKernel(arg)
|
|
if err != nil {
|
|
wwlog.Error("Could not delete kernel: %s", arg)
|
|
} else {
|
|
fmt.Printf("Kernel has been deleted: %s\n", arg)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|