`wwctl node edit` appears to not be working properly since MergeNode. This refactor, partly towards #918, resolves the issues with `node edit` and updates `profile edit` to match. Signed-off-by: Jonathon Anderson <janderson@ciq.com>
140 lines
3.3 KiB
Go
140 lines
3.3 KiB
Go
package edit
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"strings"
|
|
|
|
"github.com/spf13/cobra"
|
|
"github.com/warewulf/warewulf/internal/pkg/node"
|
|
"github.com/warewulf/warewulf/internal/pkg/util"
|
|
"github.com/warewulf/warewulf/internal/pkg/warewulfd"
|
|
"github.com/warewulf/warewulf/internal/pkg/wwlog"
|
|
"gopkg.in/yaml.v3"
|
|
)
|
|
|
|
func CobraRunE(cmd *cobra.Command, args []string) error {
|
|
if !node.CanWriteConfig() {
|
|
return fmt.Errorf("can not write to config: exiting")
|
|
}
|
|
|
|
editor := os.Getenv("EDITOR")
|
|
if editor == "" {
|
|
editor = "/bin/vi"
|
|
}
|
|
wwlog.Debug("using editor: %s", editor)
|
|
|
|
registry, regErr := node.New()
|
|
if regErr != nil {
|
|
return regErr
|
|
}
|
|
|
|
if len(args) == 0 {
|
|
for nodeID := range registry.Nodes {
|
|
args = append(args, nodeID)
|
|
}
|
|
}
|
|
wwlog.Debug("node list: %v", args)
|
|
|
|
tempFile, tempErr := os.CreateTemp(os.TempDir(), "ww4NodeEdit*.yaml")
|
|
if tempErr != nil {
|
|
return fmt.Errorf("could not create temp file: %s", tempErr)
|
|
}
|
|
defer os.Remove(tempFile.Name())
|
|
|
|
if !NoHeader {
|
|
yamlTemplate := node.UnmarshalConf(node.Node{}, nil)
|
|
if _, err := tempFile.WriteString("#nodename:\n# " + strings.Join(yamlTemplate, "\n# ") + "\n"); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
origNodes := make(map[string]*node.Node)
|
|
for _, nodeID := range args {
|
|
if n, ok := registry.Nodes[nodeID]; ok {
|
|
origNodes[nodeID] = n
|
|
}
|
|
}
|
|
|
|
if origYaml, err := util.EncodeYaml(origNodes); err != nil {
|
|
return err
|
|
} else if _, err := tempFile.Write(origYaml); err != nil {
|
|
return err
|
|
}
|
|
|
|
sum1, sumErr := util.HashFile(tempFile)
|
|
if sumErr != nil {
|
|
return sumErr
|
|
}
|
|
wwlog.Debug("original hash: %s", sum1)
|
|
|
|
for {
|
|
if err := util.ExecInteractive(editor, tempFile.Name()); err != nil {
|
|
return fmt.Errorf("editor process exited with non-zero code: %w", err)
|
|
}
|
|
|
|
sum2, sumErr := util.HashFile(tempFile)
|
|
if sumErr != nil {
|
|
return sumErr
|
|
}
|
|
wwlog.Debug("edited hash: %s", sum2)
|
|
|
|
if sum1 != sum2 {
|
|
wwlog.Debug("modified")
|
|
|
|
editYaml, err := io.ReadAll(tempFile)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
editNodes := make(map[string]*node.Node)
|
|
if err := yaml.Unmarshal(editYaml, &editNodes); err != nil {
|
|
wwlog.Error("%v\n", err)
|
|
if util.Confirm("Parse error: retry") {
|
|
continue
|
|
} else {
|
|
break
|
|
}
|
|
}
|
|
|
|
var added, deleted, updated int
|
|
for nodeID := range origNodes {
|
|
if editNode, ok := editNodes[nodeID]; !ok || editNode == nil {
|
|
wwlog.Verbose("delete node: %s", nodeID)
|
|
delete(registry.Nodes, nodeID)
|
|
deleted += 1
|
|
}
|
|
}
|
|
for nodeID := range editNodes {
|
|
if _, ok := origNodes[nodeID]; !ok {
|
|
wwlog.Verbose("add node: %s", nodeID)
|
|
added += 1
|
|
registry.Nodes[nodeID] = editNodes[nodeID]
|
|
} else if equalYaml, err := util.EqualYaml(origNodes[nodeID], editNodes[nodeID]); err != nil {
|
|
return err
|
|
} else if !equalYaml {
|
|
wwlog.Verbose("update node: %s", nodeID)
|
|
updated += 1
|
|
registry.Nodes[nodeID] = editNodes[nodeID]
|
|
}
|
|
}
|
|
|
|
if util.Confirm(fmt.Sprintf("Are you sure you want to add %d, delete %d, and update %d nodes", added, deleted, updated)) {
|
|
if err := registry.Persist(); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := warewulfd.DaemonReload(); err != nil {
|
|
return fmt.Errorf("failed to reload warewulf daemon: %w", err)
|
|
}
|
|
}
|
|
break
|
|
} else {
|
|
wwlog.Verbose("No changes")
|
|
break
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|