57d28c5bc9
Before #1628, all default constructors for nodes and profiles attempted to construct objects with pre-populated empty fields (e.g., for pointers to member structs and for collections that default to nil). Changes to MergeNode in #1629 changed this behavior intentionally to simplify the generation of minimal json; but this had the unintended side-effect of breaking existing templates that may now encounter a nil pointer, particularly when accessing member structs. Introduced here, the Expand() methods on Node and Profile are now responsible for populating such fields, and Node.Expand() is now called during template processing. Signed-off-by: Jonathon Anderson <janderson@ciq.com>
90 lines
2.1 KiB
Go
90 lines
2.1 KiB
Go
package node
|
|
|
|
import (
|
|
"net"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_Empty(t *testing.T) {
|
|
var netdev NetDev
|
|
var netdevPtr *NetDev
|
|
|
|
t.Run("test for empty", func(t *testing.T) {
|
|
if ObjectIsEmpty(netdev) != true {
|
|
t.Errorf("netdev must be empty")
|
|
}
|
|
})
|
|
t.Run("test for non empty", func(t *testing.T) {
|
|
netdev.Device = "foo"
|
|
if ObjectIsEmpty(netdev) == true {
|
|
t.Errorf("netdev must be non empty")
|
|
}
|
|
})
|
|
t.Run("test for nil pointer", func(t *testing.T) {
|
|
if ObjectIsEmpty(netdevPtr) != true {
|
|
t.Errorf("netdev must be empty")
|
|
}
|
|
})
|
|
t.Run("test for pointer assigned", func(t *testing.T) {
|
|
netdev.Ipaddr = net.ParseIP("10.10.10.1")
|
|
netdevPtr = &netdev
|
|
if ObjectIsEmpty(netdevPtr) == true {
|
|
t.Errorf("netdev must be empty")
|
|
}
|
|
})
|
|
}
|
|
|
|
func Test_Node_Expand_Flatten(t *testing.T) {
|
|
node := new(Node)
|
|
|
|
assert.Nil(t, node.Ipmi)
|
|
assert.Nil(t, node.Kernel)
|
|
assert.Nil(t, node.NetDevs)
|
|
assert.Nil(t, node.Tags)
|
|
|
|
t.Run("test expand", func(t *testing.T) {
|
|
node.Expand()
|
|
assert.Equal(t, map[string]string{}, node.Tags)
|
|
assert.Equal(t, map[string]string{}, node.Ipmi.Tags)
|
|
assert.Equal(t, "", node.Kernel.Version)
|
|
assert.Equal(t, "", node.Kernel.Args)
|
|
assert.Equal(t, map[string]*NetDev{}, node.NetDevs)
|
|
})
|
|
|
|
t.Run("test flatten", func(t *testing.T) {
|
|
node.Flatten()
|
|
assert.Nil(t, node.Ipmi)
|
|
assert.Nil(t, node.Kernel)
|
|
assert.Nil(t, node.NetDevs)
|
|
assert.Nil(t, node.Tags)
|
|
})
|
|
}
|
|
|
|
func Test_Profile_Expand_Flatten(t *testing.T) {
|
|
profile := new(Profile)
|
|
|
|
assert.Nil(t, profile.Ipmi)
|
|
assert.Nil(t, profile.Kernel)
|
|
assert.Nil(t, profile.NetDevs)
|
|
assert.Nil(t, profile.Tags)
|
|
|
|
t.Run("test expand", func(t *testing.T) {
|
|
profile.Expand()
|
|
assert.Equal(t, map[string]string{}, profile.Tags)
|
|
assert.Equal(t, map[string]string{}, profile.Ipmi.Tags)
|
|
assert.Equal(t, "", profile.Kernel.Version)
|
|
assert.Equal(t, "", profile.Kernel.Args)
|
|
assert.Equal(t, map[string]*NetDev{}, profile.NetDevs)
|
|
})
|
|
|
|
t.Run("test flatten", func(t *testing.T) {
|
|
profile.Flatten()
|
|
assert.Nil(t, profile.Ipmi)
|
|
assert.Nil(t, profile.Kernel)
|
|
assert.Nil(t, profile.NetDevs)
|
|
assert.Nil(t, profile.Tags)
|
|
})
|
|
}
|