Files
warewulf/internal/pkg/node/constructors_test.go
Jonathon Anderson eff1edd038 Fixing tests in review of #1568
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-01-17 01:27:15 -07:00

241 lines
6.7 KiB
Go

package node
import (
"testing"
"github.com/stretchr/testify/assert"
"gopkg.in/yaml.v3"
)
func newConstructorPrimaryNetworkTest(t *testing.T) NodesYaml {
var data = `
nodeprofiles:
default:
comment: This profile is automatically included for each node
overrideprofile:
network devices:
override:
device: ib0
type: profile
nodes:
test_node1:
network devices:
net0:
device: eth0
resources:
- NFSHOME
test_node2:
primary network: net1
network devices:
net0:
device: eth0
net1:
device: eth1
test_node3:
network devices:
net0:
device: eth0
net1:
device: eth1
test_node4:
primary network: net3
network devices:
net0:
device: eth0
net1:
device: eth1
test_node5:
profiles:
- overrideprofile
test_node6:
profiles:
- overrideprofile
network devices:
override:
device: ib1
resources:
NFSHOME:
mountpoint: /home
`
var ret NodesYaml
err := yaml.Unmarshal([]byte(data), &ret)
assert.NoError(t, err)
return ret
}
func Test_Primary_Network(t *testing.T) {
c := newConstructorPrimaryNetworkTest(t)
test_node1, err := c.GetNode("test_node1")
assert.NoError(t, err)
test_node2, err := c.GetNode("test_node2")
assert.NoError(t, err)
test_node3, err := c.GetNode("test_node3")
assert.NoError(t, err)
test_node4, err := c.GetNode("test_node4")
assert.NoError(t, err)
test_node5, err := c.GetNode("test_node5")
assert.NoError(t, err)
test_node6, err := c.GetNode("test_node6")
assert.NoError(t, err)
t.Run("Primary network with one network, nothing set", func(t *testing.T) {
if test_node1.PrimaryNetDev != "net0" {
t.Errorf("primary network isn't net0 but: %s", test_node1.PrimaryNetDev)
}
if !test_node1.NetDevs["net0"].primary {
t.Errorf("primary flag isn't set for net0")
}
})
t.Run("Primary network with two networks, primary is net1", func(t *testing.T) {
if test_node2.PrimaryNetDev != "net1" {
t.Errorf("primary network isn't net1 but: %s", test_node2.PrimaryNetDev)
}
if test_node2.NetDevs["net0"].primary {
t.Errorf("primary flag is set for net0")
}
if !test_node2.NetDevs["net1"].primary {
t.Errorf("primary flag isn't set for net1")
}
})
t.Run("Primary network with two networks, primary isn't set", func(t *testing.T) {
if test_node3.PrimaryNetDev != "net0" && test_node3.PrimaryNetDev != "net1" {
t.Errorf("network wasn't sanitized")
}
if test_node3.NetDevs["net0"].primary == test_node3.NetDevs["net1"].primary {
t.Errorf("primary flag isn't set at all")
}
})
// debateable what result we await here, on refactoring primary network w
// will be one of the valid networks
t.Run("Primary network with two networks, primary available", func(t *testing.T) {
if test_node4.PrimaryNetDev == "net3" {
t.Errorf("primary network isn net3, although node hasn't this network")
}
if test_node4.NetDevs["net0"].primary == test_node4.NetDevs["net1"].primary {
t.Errorf("node primary flag isn't set")
}
})
t.Run("defined in profile", func(t *testing.T) {
assert.Equal(t, "ib0", test_node5.NetDevs["override"].Device)
assert.Equal(t, "profile", test_node5.NetDevs["override"].Type)
})
t.Run("redefined in profile", func(t *testing.T) {
assert.Equal(t, "ib1", test_node6.NetDevs["override"].Device)
assert.Equal(t, "profile", test_node6.NetDevs["override"].Type)
})
t.Run("resource is defined", func(t *testing.T) {
assert.Contains(t, test_node1.Resources, "NFSHOME")
res, err := c.GetResource(test_node1.Resources[0])
assert.NoError(t, err)
assert.Contains(t, res, "mountpoint")
})
}
var findDiscoverableNodeTests = []struct {
description string
discoverable_nodes []string
discovered_node string
discovered_interface string
succeed bool
}{
{"no discoverable nodes", []string{}, "", "", false},
{"all nodes discoverable", []string{"test_node1", "test_node2", "test_node3", "test_node4"}, "test_node1", "net0", true},
{"discover primary", []string{"test_node2"}, "test_node2", "net1", true},
{"discovery without primary", []string{"test_node3"}, "test_node3", "net0", true},
}
func Test_FindDiscoverableNode(t *testing.T) {
for _, tt := range findDiscoverableNodeTests {
t.Run(tt.description, func(t *testing.T) {
config := newConstructorPrimaryNetworkTest(t)
for _, node := range tt.discoverable_nodes {
config.Nodes[node].Discoverable = "true"
}
discovered_node, discovered_interface, err := config.FindDiscoverableNode()
if !tt.succeed {
assert.Error(t, err)
} else {
assert.NoError(t, err)
assert.Equal(t, tt.discovered_node, discovered_node.Id())
assert.Equal(t, tt.discovered_interface, discovered_interface)
}
})
}
}
func Test_Profile_Overlay_Merge(t *testing.T) {
nodesconf := `
nodeprofiles:
profile1:
runtime overlay:
- p1o1
- p1o2
profile2:
runtime overlay:
- p2o1
- p2o2
nodes:
node1:
profiles:
- profile1
node2:
profiles:
- profile1
- profile2
node3:
runtime overlay:
- n3o1
- n3o2
profiles:
- profile1
node4:
runtime overlay:
- n1o1
- n1o2
profiles:
- profile1
- profile2
node5:
runtime overlay:
- n1o1
- ~p1o2
profiles:
- profile1
- profile2
`
assert := assert.New(t)
var ymlSrc NodesYaml
err := yaml.Unmarshal([]byte(nodesconf), &ymlSrc)
assert.NoError(err)
nodes, err := ymlSrc.FindAllNodes()
assert.NoError(err)
nodemap := make(map[string]*Node)
for i := range nodes {
nodemap[nodes[i].Id()] = &nodes[i]
}
assert.Contains(nodemap, "node1")
assert.ElementsMatch(nodemap["node1"].RuntimeOverlay, []string{"p1o1", "p1o2"})
assert.Contains(nodemap, "node2")
assert.ElementsMatch(nodemap["node2"].RuntimeOverlay, []string{"p1o1", "p1o2", "p2o1", "p2o2"})
assert.Contains(nodemap, "node3")
assert.ElementsMatch(nodemap["node3"].RuntimeOverlay, []string{"p1o1", "p1o2", "n3o1", "n3o2"})
assert.Contains(nodemap, "node4")
assert.ElementsMatch(nodemap["node4"].RuntimeOverlay, []string{"p1o1", "p1o2", "p2o1", "p2o2", "n1o1", "n1o2"})
assert.Contains(nodemap, "node5")
assert.ElementsMatch(nodemap["node5"].RuntimeOverlay, []string{"p1o1", "p1o2", "~p1o2", "p2o1", "p2o2", "n1o1"})
}
func Test_negated_list(t *testing.T) {
assert := assert.New(t)
list := []string{"tok1", "tok2"}
list2 := []string{"tok1", "tok2", "~tok3"}
list3 := []string{"tok1", "tok2", "~tok3", "~tok3"}
list4 := []string{"tok1", "tok2", "~tok3", "~tok4"}
list5 := []string{"tok1", "tok3", "~tok3", "tok2"}
assert.Equal([]string{"tok3"}, negList(list2))
assert.Equal(list, cleanList(list2))
assert.Equal(list, cleanList(list3))
assert.Equal(list, cleanList(list4))
assert.Equal(list, cleanList(list5))
}