Merge pull request #1946 from adrianreber/2025-07-14-system-tmpdir

fix(wwctl): Create overlay edit tempfile in tmpdir

CHANGELOG.md

@@ -20,6 +20,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Refactored overlay class. #1968
 - `wwclient` places files from the runtime overlay atomically. #1307, #1975
 - `wwclient` skips files that do not appear to have been modified. #1984
+- `wwctl overlay edit` again writes temporary files to the default location.
+  (After #1886 better resolves the underlying issue from #1473.) #1946
 
 ### Fixed
 

CONTRIBUTORS.md

@@ -48,3 +48,4 @@
 * Rafael Lopez <raflopez1@gmail.com> @rafalop
 * Arian Cabrera [@acabrera86](https://github.com/acabrera86)
 * Dacian Reece-Stremtan <dacianstremtan@gmail.com> [@dacianstremtan](https://github.com/dacianstremtan)
+* Adrian Reber <areber@redhat.com>

internal/app/wwctl/overlay/edit/main.go

@@ -47,7 +47,7 @@ func CobraRunE(cmd *cobra.Command, args []string) (err error) {
 		return fmt.Errorf("%s does not exist. Use '--parents' option to create automatically", overlayFileDir)
 	}
 
-	tempFile, tempFileErr := os.CreateTemp(myOverlay.Path(), "ww-overlay-edit-")
+	tempFile, tempFileErr := os.CreateTemp("", "ww-overlay-edit-")
 	if tempFileErr != nil {
 		return fmt.Errorf("unable to create temporary file for editing: %s", tempFileErr)
 	}