Commit Graph

1749 Commits

Author SHA1 Message Date
Jonathon Anderson
8321193645 Refactor and document config/datastructure
Also adjusted case for initialisms (e.g., DHCP, TFTP, NFS).

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-19 14:02:43 -06:00
Jonathon Anderson
cfdf179e16 Remove SetDynamicDefaults from Parse
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-19 14:02:43 -06:00
Jonathon Anderson
387cd0f7be Refactor BaseConf Read and Parse
Also refactor New and Get to return pointers to match BaseConf methods.
This makes calling the methods immediately on the return values of the
constructors easier.

Also move config.ConfigFile to buildconfig.go.in. ConfigFile is still
used by wwctl as a default config file to reference; but it is removed
from other locations now.

Removed Persist, as nothing called it.

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-19 14:02:43 -06:00
Jonathon Anderson
a10fdb3808 Remove config.DataStore()
Comments in the code were already disparaging of config.DataStore(), but
implied that its presence made other code more readable. It was only
used in two places and, imo, how I've refactored it is more explicit and
clear than it was.

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-19 14:02:43 -06:00
Jonathon Anderson
af6c91ade3 Rename BaseConf.Initialized to BaseConf.InitializedFromFile
Initialized could be interpreted to mean dynamically initialized as
well. This new name removes that ambiguity.

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-19 14:02:43 -06:00
Jonathon Anderson
70292276e2 Rename BaseConf.New to BaseConf.Get
Since BaseConf.New could return a cached BaseConf, rather than always
constructing a new struct, I've renamed it to Get to more accurately
reflect its use. A new New() method is called by Get and always
initializes a new struct.

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-19 14:02:43 -06:00
Jonathon Anderson
f78e6b73b1 Rename ControllerConf to BaseConfig
Also moved BaseConfig to a new source file, co-located with its
constructors and methods, and added doc comments.

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-19 14:02:43 -06:00
Jonathon Anderson
c461e65a98 Rename pkg/warewulfconf to pkg/config
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-19 14:02:43 -06:00
Jonathon Anderson
b6e6795dee Removed "glob" from node pattern description
A glob is a pattern that supports * and ? wildcards. This is not
supported for node patterns. I'd call these "hostlist" patterns; but
easier to just leave it generic for now until and unless there is
documentation to refer to on the website about the pattern type.

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-16 20:58:39 -06:00
Jonathon Anderson
e693ca9cd4 Merge remote-tracking branch 'jason/issue/658' into development
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-16 18:43:59 -06:00
Christian Goll
12968f306a Merge pull request #780 from anderbubble/fix-writing
Fix writing of nodes.conf
2023-04-18 07:14:58 +02:00
Jonathon Anderson
cc714008ef Add doc comments for two methods
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-16 07:24:14 -06:00
Jonathon Anderson
2319906d97 Fix writing of nodes.conf
The caching functionality of nodes.conf, and the optional persistence
functionality that came with it, appears to have been preventing
actually writing the configuration to disk in all cases. This change
fixes the ability to write to nodes.conf.

Somewhat opinionatedly, this change removes the caching functionality of
nodes.conf. The tests have also been updated to use real files for i/o
rather than tying into the caching system, making them more accurately
test the ability of Warewulf to actually read and write its
configuration.

Fixes #779

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-04-14 10:53:31 -06:00
jason yang
d73a6f269c fix the code
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
2023-04-12 12:04:53 +00:00
jason yang
7500688f82 merge the latest development
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
2023-04-12 10:29:35 +00:00
jason yang
0faada6aae refactor the profile add
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
2023-04-12 10:27:44 +00:00
Christian Goll
0f2fcb326f Merge pull request #670 from mslacken/FixProfileAdd
correct behavior of profile add to yes flag
2023-04-12 08:58:10 +02:00
Christian Goll
75e75b57d3 Merge pull request #774 from JasonYangShadow/issue/773
container list test can fail in wrong time zone
2023-04-12 08:57:24 +02:00
jason yang
db048bfa73 update the main_test to ignore time zone
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
2023-04-12 06:26:51 +00:00
Christian Goll
0ad69ca3ce Merge pull request #677 from mslacken/RefactorFlags
Refator the CreateFlags command
2023-04-11 14:17:28 +02:00
Christian Goll
5f5724c8a9 Merge branch 'development' into RefactorFlags 2023-04-11 14:17:13 +02:00
Christian Goll
48c08f3fd7 Merge pull request #719 from hpcng/hashConf
more secure edit command
2023-04-11 11:44:01 +02:00
Christian Goll
1c6300b713 Merge pull request #746 from hpcng/dependabot/go_modules/development/github.com/fatih/color-1.15.0
Bump github.com/fatih/color from 1.13.0 to 1.15.0
2023-03-30 09:56:26 +02:00
dependabot[bot]
a09a850233 Bump github.com/fatih/color from 1.13.0 to 1.15.0
Bumps [github.com/fatih/color](https://github.com/fatih/color) from 1.13.0 to 1.15.0.
- [Release notes](https://github.com/fatih/color/releases)
- [Commits](https://github.com/fatih/color/compare/v1.13.0...v1.15.0)

---
updated-dependencies:
- dependency-name: github.com/fatih/color
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-30 07:52:49 +00:00
Christian Goll
ef4480b7b6 Merge pull request #759 from mslacken/development
cleanup fallout from update of grpc
2023-03-30 09:51:50 +02:00
Christian Goll
17ade3fdcc cleanup fallout from update of grpc
Signed-off-by: Christian Goll <cgoll@suse.de>
2023-03-30 09:50:09 +02:00
Christian Goll
efdf55ecb9 Merge pull request #745 from hpcng/dependabot/go_modules/development/google.golang.org/grpc/cmd/protoc-gen-go-grpc-1.3.0
Bump google.golang.org/grpc/cmd/protoc-gen-go-grpc from 1.2.0 to 1.3.0
2023-03-30 09:45:04 +02:00
dependabot[bot]
591f7670aa Bump google.golang.org/grpc/cmd/protoc-gen-go-grpc from 1.2.0 to 1.3.0
Bumps [google.golang.org/grpc/cmd/protoc-gen-go-grpc](https://github.com/grpc/grpc-go) from 1.2.0 to 1.3.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.2.0...v1.3.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc/cmd/protoc-gen-go-grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-30 07:43:19 +00:00
Christian Goll
4a1d5f29aa Merge pull request #718 from hpcng/dependabot/go_modules/development/github.com/grpc-ecosystem/grpc-gateway/v2-2.15.2
Bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.10.0 to 2.15.2
2023-03-30 09:42:21 +02:00
dependabot[bot]
72cd9ae946 Bump github.com/grpc-ecosystem/grpc-gateway/v2 from 2.10.0 to 2.15.2
Bumps [github.com/grpc-ecosystem/grpc-gateway/v2](https://github.com/grpc-ecosystem/grpc-gateway) from 2.10.0 to 2.15.2.
- [Release notes](https://github.com/grpc-ecosystem/grpc-gateway/releases)
- [Changelog](https://github.com/grpc-ecosystem/grpc-gateway/blob/main/.goreleaser.yml)
- [Commits](https://github.com/grpc-ecosystem/grpc-gateway/compare/v2.10.0...v2.15.2)

---
updated-dependencies:
- dependency-name: github.com/grpc-ecosystem/grpc-gateway/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-30 07:37:39 +00:00
Christian Goll
9a72447115 Merge pull request #710 from hpcng/dependabot/go_modules/development/github.com/manifoldco/promptui-0.9.0
Bump github.com/manifoldco/promptui from 0.8.0 to 0.9.0
2023-03-30 09:36:40 +02:00
Christian Goll
3e49adaf95 Merge pull request #757 from hpcng/mslacken-patch-1
Update go version to 1.17
2023-03-30 09:35:41 +02:00
Jonathon Anderson
3786e03cb2 Update warewulf-logo.png
Image taken from https://github.com/hpcng/warewulf-logos/

* Warewulf_icon_clr_L.png

Signed-off-by: Jonathon Anderson <janderson@ciq.co>
2023-03-29 13:18:40 -06:00
dependabot[bot]
132f5db0ea Bump github.com/manifoldco/promptui from 0.8.0 to 0.9.0
Bumps [github.com/manifoldco/promptui](https://github.com/manifoldco/promptui) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/manifoldco/promptui/releases)
- [Changelog](https://github.com/manifoldco/promptui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/manifoldco/promptui/compare/v0.8.0...v0.9.0)

---
updated-dependencies:
- dependency-name: github.com/manifoldco/promptui
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-29 12:59:42 +00:00
Christian Goll
4333ffe904 Merge pull request #748 from JasonYangShadow/issue/690
KERNEL VERSION column is too short
2023-03-29 14:58:44 +02:00
jason yang
fd768145a9 add test case for container list
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
2023-03-29 12:44:12 +00:00
jason yang
6dcd26322a add test case for profile list
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
2023-03-29 10:35:17 +00:00
Christian Goll
7265083ed0 added test for node list
Signed-off-by: Christian Goll <cgoll@suse.com>
2023-03-28 20:56:12 +02:00
Christian Goll
f936c93a15 Update go version to 1.17
some dependa bot PRs require go 1.17
2023-03-28 19:36:42 +02:00
jason yang
6f200d65a6 Merge branch 'development' into issue/690 2023-03-28 07:09:33 +00:00
Christian Goll
c476ba8ec4 hash checking for profile edit
Signed-off-by: Christian Goll <cgoll@suse.de>
2023-03-24 19:47:22 +01:00
Christian Goll
b4acf0fdf2 added hash check for node edit
Signed-off-by: Christian Goll <cgoll@suse.de>
2023-03-24 19:47:22 +01:00
Christian Goll
ee4f9d53d6 add hash function
Signed-off-by: Christian Goll <cgoll@suse.de>
2023-03-24 19:47:22 +01:00
Christian Goll
4582a1f59e fix linting for disabled batch test
Signed-off-by: Christian Goll <cgoll@suse.de>
2023-03-24 19:47:22 +01:00
Olaf Mersmann
daaf41ffad Add missing packages to build on EL8
Building on a fresh Rocky Linux 8.7 box gpgme-devel and libassum-devel
in addition to the packages already listed.
2023-03-24 19:47:22 +01:00
Christian Goll
f4c78d1a05 Merge pull request #755 from mslacken/development
fix linting for disabled batch test
2023-03-24 09:53:54 +01:00
Christian Goll
aee7738be1 fix linting for disabled batch test
Signed-off-by: Christian Goll <cgoll@suse.de>
2023-03-24 09:52:38 +01:00
Christian Goll
321df0ba94 Merge pull request #754 from olafmersmann/fix_el8-pkgs
Add missing packages to build on EL8
2023-03-24 08:24:07 +01:00
Christian Goll
e680e3d475 Merge pull request #753 from anderbubble/disable-TestBatchPool
Disable TestBatchPool
2023-03-24 06:46:40 +01:00
Brian Clemens
d4c462f42c Merge pull request #752 from anderbubble/userdocs-debugging
Add a userdocs page for using delve to debug tests
2023-03-24 10:16:11 +09:00