Commit Graph

3064 Commits

Author SHA1 Message Date
Jonathon Anderson
a0179f1432 Resolve issues identifies by staticcheck
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-06 22:11:17 -07:00
Jonathon Anderson
3f652ceb02 Run staticcheck as part of GitHub CI
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-06 22:11:13 -07:00
Jonathon Anderson
537358f88e Merge pull request #1700 from anderbubble/warewulf-conf-network
Fix handling of CIDR values in warewulf.conf
2025-02-06 21:32:34 -07:00
Xu YANG
8088112c30 Merge pull request #1709 from anderbubble/document-dhcp-template-variable
Document `warewulf.conf:dhcp.template`
2025-02-07 13:26:33 +09:00
Jonathon Anderson
73f34d0099 Restore server network auto-detection
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-06 20:46:20 -07:00
Jonathon Anderson
abc3a0ee2d Fix detection of OS
The previous method broke on ubuntu, where the value of ID was not quoted in
`/etc/os-release`. This broke tests that depended on paths set on known OSes.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-06 20:46:20 -07:00
Jonathon Anderson
2e1466fc7e Fix handling of CIDR values in warewulf.conf
- Fixes: #1541
- Fixes: #1594

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-06 20:46:20 -07:00
Jonathon Anderson
c32b752545 Document warewulf.conf:dhcp.template
- Closes: #1701

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-06 20:39:44 -07:00
Xu YANG
470f8c65d5 Merge pull request #1707 from anderbubble/remove-syslog
Remove `warewulf.conf:syslog`
2025-02-07 12:08:48 +09:00
Xu YANG
9a102c19af Merge pull request #1708 from anderbubble/ssh-key-default
Re-order SSH key types to make ed25519 default
2025-02-07 12:07:06 +09:00
Xu YANG
bd6f3f4204 Merge pull request #1706 from anderbubble/image-size
Only calculate image chroot size when requested
2025-02-07 12:00:58 +09:00
Xu YANG
5f7713cd4c Merge branch 'main' into image-size 2025-02-07 12:00:50 +09:00
Xu YANG
7b9db081a1 Merge pull request #1688 from anderbubble/dracut-asset-tag-urlencode
Urlencode asset keys during dracut boot
2025-02-07 11:59:46 +09:00
Xu YANG
dd5f083022 Merge branch 'main' into dracut-asset-tag-urlencode 2025-02-07 11:55:03 +09:00
Xu YANG
d7b59ca6bb Merge pull request #1711 from anderbubble/merge-zero-net-ip
Prevent merging of zero-value net.IP fields
2025-02-07 11:51:15 +09:00
Jonathon Anderson
6bfcfc5fda Prevent merging of zero-value net.IP fields
- Fixes: #1710

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-06 16:43:21 -07:00
Jonathon Anderson
4809641ef6 Re-order SSH key types to make ed25519 default
- Fixes: #981

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 23:27:29 -07:00
Jonathon Anderson
a975c5efb6 Remove labels from issue templates
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 22:29:39 -07:00
Jonathon Anderson
e449d10d65 Add types to issue templates
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 22:27:51 -07:00
Jonathon Anderson
fa46794d38 New OPTIONS variable for warewulfd.service
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 22:16:08 -07:00
Jonathon Anderson
89721c6832 Remove warewulf.conf:syslog
- Fixes: #1606

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 21:58:39 -07:00
Xu YANG
77bf4c7f98 Merge pull request #1704 from anderbubble/overlay-edit-file-path
Create temporary files in overlay directory during `wwctl overlay edit`
2025-02-06 13:11:39 +09:00
Xu YANG
b1b802def2 Merge pull request #1703 from anderbubble/overlay-import-permissions
Set execute permissions for intermediate directories
2025-02-06 13:06:22 +09:00
Jonathon Anderson
8bf35c7657 Only calculate image chroot size when requested
- Fixes: #1504

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 20:51:41 -07:00
Jonathon Anderson
05923d4044 Create temporary files in overlay directory during wwctl overlay edit
- Fixes: #1473

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 20:27:55 -07:00
Jonathon Anderson
6a250f3f96 Set execute permissions for intermediate directories
- Fixes: #1655

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 20:04:22 -07:00
Jonathon Anderson
36dca0dfa3 Merge pull request #1702 from mslacken/completionProfiles
add completion for profile list
2025-02-05 20:00:24 -07:00
Jonathon Anderson
b05e384560 Refactor to completions.Profiles
Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 19:09:04 -07:00
Christian Goll
60872bd42e Add completion for profile list
- Closes: #1696

Signed-off-by: Christian Goll <cgoll@suse.com>
2025-02-05 19:08:58 -07:00
Jonathon Anderson
c1305fa68a Merge pull request #1696 from anderbubble/build-improvements
Simplify Makefile and spec
2025-02-05 09:31:06 -07:00
Jonathon Anderson
6dbfa52dbc Create site overlay directory
This was previously added to warewulf.spec, but the directory wasn't actually
being created.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 09:23:19 -07:00
Jonathon Anderson
ea7cd49f85 Simplify Makefile and spec
- explicitly indicate what to include in dist
- prevent duplication of files in specfile

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-05 09:23:06 -07:00
Christian Goll
987a3fd621 Merge pull request #1698 from anderbubble/overlay-create-root-dir
Create site overlay directory
2025-02-04 09:03:33 +01:00
Jonathon Anderson
38791c74ad Create site overlay directory
-Fixes: #1690

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-04 09:03:08 +01:00
Christian Goll
5517a26c6f Merge pull request #1697 from anderbubble/warewulfd-kernel-data-panic
Fix a panic in warewulfd when no kernel fields are specified
2025-02-04 09:01:59 +01:00
Jonathon Anderson
5bc82f97cc Urlencode asset keys during dracut boot
- Fixes: #1610

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-03 13:49:29 -07:00
Christian Goll
e01707173b Merge pull request #1692 from anderbubble/wwinit-mounts
Don't mount /run during wwinit
2025-02-03 14:07:15 +01:00
Christian Goll
916ebec8df Merge pull request #1686 from anderbubble/document-wwclient-port
Document setting the wwclient port
2025-02-03 14:06:27 +01:00
Christian Goll
233e52b440 Merge pull request #1691 from anderbubble/grub-dracut-init
Specify init=/init when booting with Grub+dracut
2025-02-03 14:05:41 +01:00
Jonathon Anderson
7c8a1a4e1b Specify init=/init when booting with Grub+dracut
- Fixes: #1573

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-03 13:56:18 +01:00
Christian Goll
bb0bb21472 Merge pull request #1685 from anderbubble/node-list-maps
wwctl node list <--yaml|--json> outputs a map keyed by node name
2025-02-03 12:33:54 +01:00
Jonathon Anderson
1f607b679b wwctl node list <--yaml|--json> outputs a map keyed by node name
- Fixes: #1667

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-03 12:32:50 +01:00
Christian Goll
8c342ebdcd Merge pull request #1684 from anderbubble/upgrade-no-backup
Don't attempt to back-up an output file that doesn't exist during upgrade
2025-02-03 12:17:57 +01:00
Jonathon Anderson
8b26088083 Don't attempt to back-up an output file that doesn't exist during upgrade
- Fixes: #1671

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-03 12:17:41 +01:00
Christian Goll
ff88afbf6d Merge pull request #1683 from anderbubble/prefer-parent-values
Prefer parent profile values over child profile values
2025-02-03 12:16:27 +01:00
Jonathon Anderson
e3d90cd323 Prefer parent profile values over child profile values.
- Fixes: #1672

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-03 12:16:12 +01:00
Jonathon Anderson
6ad7178ad8 Fix a panic in warewulfd when no kernel fields are specified
- Fixes: #1689

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-03 03:48:10 -07:00
Christian Goll
cab57f51b7 Merge pull request #1680 from anderbubble/wwctl-upgrade-not-netdevs
Don't populate NetDevs[].Type or NetDevs[].Netmask during upgrade
2025-02-03 11:00:37 +01:00
Jonathon Anderson
032db29f87 Don't populate NetDevs[].Type or NetDevs[].Netmask during upgrade
- Closes: #1661

NetDev defaults don't behave quite the same as standard fields, because they
need to be set per-device. Meanwhile, trying to set a value may erroneously
override values that are on the default profile.

Switch this to a warning rather than attempting to take explicit action.

Signed-off-by: Jonathon Anderson <janderson@ciq.com>
2025-02-03 11:00:12 +01:00
Xu YANG
87b9ad33ff Merge pull request #1693 from anderbubble/warewulf-recommends-ipmitool
Recommend installing ipmitool with Warewulf package
2025-02-03 13:55:15 +09:00