We are pinning version 1.17 for the linting workflow. Go 1.16
has been EOL for almost two years and even EL7 releases have
1.17 available now. Removed 1.16 from our test matrix.
This commit does the following:
* Update the build testing workflow to run on development branch
* Remove go 1.16 and add 1.19 to test build workflow
Signed-off-by: Michael L. Young <myoung@ciq.co>
If a fork is running GH actions, do not create the static
documentation and try to push to the warewulf documentation repo.
Signed-off-by: Michael L. Young <myoung@ciq.co>
Error logging for overlay show rendering incorrectly checked
the overlay name rather than the path to the file. It also
used wwlog (which goes to stderr) to output the render. This
commit replaces explicit args[] references with their named
equivalents from earlier in the function, correcting those
references along the way, and outputs the final render with
fmt.Print.
Commit d8cd6049 introduced erroneous output coming from an
inner function of container show, and (seemingly) erroneously
replaces valid kernel versions with "not found". This commit
fixes both of those issues, and moves the output to the outer
cli function.
wwlog provides named loggers for each level, which requires
less code and is clearer than wwlog.Printf. The code has
included a mix of both, but this commit consolidates existing
code on the per-level functions.
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
It appears that the intended behavior of overlay chown was changed
in 00d8d42e9, but the argument handling was not updated to reflect
the removal of overlayKind. This led to a crash when only the
uid was specified, and a processing of the gid as the uid
otherwise.
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
Specifying 0 for gid as a default during chown causes the
gid to be changed to 0 when left unspecified. Changing the
default value to -1 causes the gid to be left unmodified
when unspecified, which is a less surprising behavior.
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
warewulf.datastore is being set to a null string, which is simply
prompting it to use the default.
dhcp.template doesn't appear to be used any more, now that dhcp
configuration has moved into the host overlay.
tftp.tftproot doesn't appear to be doing anything, is simply setting to
the empty string anyway, and is otherwise compiled-in.
Signed-off-by: Jonathon Anderson <janderson@ciq.co>
