0b3e862bea
I noticed that some wwlog calls included a trailing newline, but others did not. I tested both in isolation and discovered that the behavior was consistent regardless of whether a trailing newline was included. I further confirmed in code that wwlog appends a trailing newline automatically if it is not present; so a trailing newline is unnecessary in individual calls. This commit removes trailing newlines from all calls to make them consistent. It also replaces two calls to wwlog.Printf. (see #534) Signed-off-by: Jonathon Anderson <janderson@ciq.co>
73 lines
1.3 KiB
Go
73 lines
1.3 KiB
Go
package console
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/hpcng/warewulf/internal/pkg/node"
|
|
"github.com/hpcng/warewulf/internal/pkg/power"
|
|
"github.com/hpcng/warewulf/internal/pkg/wwlog"
|
|
"github.com/hpcng/warewulf/pkg/hostlist"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
func CobraRunE(cmd *cobra.Command, args []string) error {
|
|
var returnErr error = nil
|
|
|
|
nodeDB, err := node.New()
|
|
if err != nil {
|
|
wwlog.Error("Could not open node configuration: %s", err)
|
|
os.Exit(1)
|
|
}
|
|
|
|
nodes, err := nodeDB.FindAllNodes()
|
|
if err != nil {
|
|
wwlog.Error("Could not get node list: %s", err)
|
|
os.Exit(1)
|
|
}
|
|
|
|
args = hostlist.Expand(args)
|
|
|
|
if len(args) > 0 {
|
|
nodes = node.FilterByName(nodes, args)
|
|
} else {
|
|
//nolint:errcheck
|
|
cmd.Usage()
|
|
os.Exit(1)
|
|
}
|
|
|
|
if len(nodes) == 0 {
|
|
fmt.Printf("No nodes found\n")
|
|
os.Exit(1)
|
|
}
|
|
|
|
for _, node := range nodes {
|
|
|
|
if node.Ipmi.Ipaddr.Get() == "" {
|
|
wwlog.Error("%s: No IPMI IP address", node.Id.Get())
|
|
continue
|
|
}
|
|
|
|
ipmiCmd := power.IPMI{
|
|
NodeName: node.Id.Get(),
|
|
HostName: node.Ipmi.Ipaddr.Get(),
|
|
Port: node.Ipmi.Port.Get(),
|
|
User: node.Ipmi.UserName.Get(),
|
|
Password: node.Ipmi.Password.Get(),
|
|
AuthType: "MD5",
|
|
Interface: node.Ipmi.Interface.Get(),
|
|
}
|
|
|
|
err := ipmiCmd.Console()
|
|
|
|
if err != nil {
|
|
wwlog.Error("%s: Console problem", node.Id.Get())
|
|
returnErr = err
|
|
continue
|
|
}
|
|
|
|
}
|
|
|
|
return returnErr
|
|
}
|